Update to latest vcpkg (fixes Windows builds) #5331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to see if hunspell will now build
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
vadi2
changed the title
SlySven
reviewed
Aug 29, 2021
|
Updating vcpkg clearly needed some extra dependencies installed on the osx side of things, hence the extra step to install them. But the motivation in updating vcpkg was still to fix windows builds. Looks good to me. |
demonnic
approved these changes
Aug 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Update the vcpkg ports we used from November 2020 to the latest as of today.
Motivation for adding to Mudlet
Fixed Windows builds to work, which got broken because
mingw-w64-i686-pkg-config-0.29.2-1-any.pkg.tar.xzwas not available in any download mirrors anymore.Other info
It's a concern that vcpkg is limited by 3rd party mirrors like this. It also took a long while to get to this stage - all vcpkg versions inbetween were broken by various issues. Thankfully the vcpkg team is quick and on top of fixing them.