Improvement: expose cecho2ansi and have it work for non-ansi color names as well #5672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
demonnic
added
the
needs documentation
SlySven
added
the
Lua only
demonnic
removed
the
needs documentation
keneanung
approved these changes
Dec 1, 2021
vadi2
approved these changes
Dec 1, 2021
vadi2
pushed a commit
to SlySven/Mudlet
that referenced
this pull request
Jan 17, 2022
…mes as well (Mudlet#5672) #### Brief overview of PR changes/additions While perusing the ansi conversion functions I realized we were doing all the work of cecho2ansi but had not exposed it as separate functionality. Since we have done so for d and hecho, it made sense to me to perform this refactor. In the process I also added support for colors which are not named ansi colors but exist in the color table. #### Motivation for adding to Mudlet More complete API, consistency across the c/d/h variants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
While perusing the ansi conversion functions I realized we were doing all the work of cecho2ansi but had not exposed it as separate functionality. Since we have done so for d and hecho, it made sense to me to perform this refactor.
In the process I also added support for colors which are not named ansi colors but exist in the color table.
Motivation for adding to Mudlet
More complete API, consistency across the c/d/h variants.
Other info (issues closed, discussion etc)
Tests will fail until #5671 is merged and then pulled back into this branch.Release post highlight