Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrastructure: Adjust test instructions in README #6291

Merged

Conversation

demonnic
Copy link
Member

@demonnic demonnic commented Sep 6, 2022

Brief overview of PR changes/additions

Updates to the README.md for running the Busted tests for Mudlet. Fixes linting issues with the file layout, and adjusts the instructions for dealing with LUA_PATH and LUA_CPATH to account for the issues seen in #6058

You can view the changes rendered at https://github.com/demonnic/Mudlet/tree/update_windows_busted_instructions/src/mudlet-lua/tests

Motivation for adding to Mudlet

Keep someone from accidentally blowing up their Mudlet while trying to setup to run tests.

Other info (issues closed, discussion etc)

closes #6058

@demonnic demonnic requested a review from a team as a code owner September 6, 2022 18:35
@add-deployment-links
Copy link

add-deployment-links bot commented Sep 6, 2022

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

@mudlet-machine-account mudlet-machine-account added this to the 4.17.0 milestone Sep 6, 2022
@demonnic demonnic merged commit cd7aa73 into Mudlet:development Sep 6, 2022
@demonnic demonnic deleted the update_windows_busted_instructions branch September 6, 2022 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default Mudlet paths overridden if LUA_PATH/LUA_CPATH is set
3 participants