Fixed a compiler warning of deprecated uniqueIdentifier #166

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@Zhukn1

Zhukn1 commented Jul 17, 2013

Fixed a compiler warning of the deprecated call to uniqueIdentifier in iOS 6. It only switches off the diagnostics for this one line of code so isn't harmful for the rest of the project.

@vinceyuan

This comment has been minimized.

Show comment
Hide comment
@vinceyuan

vinceyuan Jul 30, 2013

When you upload an app to App Store, Apple will check the binary automatically and find it calls uniqueIdentifier API. You app will be rejected immediately.
I think we have to remove uniqueIdentifier and drop support of iOS 5.

When you upload an app to App Store, Apple will check the binary automatically and find it calls uniqueIdentifier API. You app will be rejected immediately.
I think we have to remove uniqueIdentifier and drop support of iOS 5.

This comment has been minimized.

Show comment
Hide comment
@Zhukn1

Zhukn1 Jul 30, 2013

Owner

No, that's not a correct argument. Apple also checks for the iOS version fork. This line of code is marked pre iOS 6. I already have several apps on the store with this fork and without the compiler warnings.

I think it'll be more logical to drop iOS 5 as soon as we get the final iOS 7 release.

Owner

Zhukn1 replied Jul 30, 2013

No, that's not a correct argument. Apple also checks for the iOS version fork. This line of code is marked pre iOS 6. I already have several apps on the store with this fork and without the compiler warnings.

I think it'll be more logical to drop iOS 5 as soon as we get the final iOS 7 release.

@sorentoft

This comment has been minimized.

Show comment
Hide comment
@sorentoft

sorentoft Aug 16, 2013

I am afraid vinceyuan is right. I just tried uploading my app and it was rejected because of the call to "[UIDevice currentDevice].uniqueIdentifier" in VerificationController. Once I deleted the check the app was approved (and it was the only change I made). My app deployment target is 5.1.
I believe Apple recently changed this in their automatic verification

I am afraid vinceyuan is right. I just tried uploading my app and it was rejected because of the call to "[UIDevice currentDevice].uniqueIdentifier" in VerificationController. Once I deleted the check the app was approved (and it was the only change I made). My app deployment target is 5.1.
I believe Apple recently changed this in their automatic verification

@Zhukn1

This comment has been minimized.

Show comment
Hide comment
@Zhukn1

Zhukn1 Aug 18, 2013

Ok, now my app also got rejected. Apple did change the automatic verification process.
Thank you, @sorentoft and my apologies to @vinceyuan. I will now delete the pull request because it's not relevant any more. The only way is to completely remove the uniqueIdentifier call.

Zhukn1 commented Aug 18, 2013

Ok, now my app also got rejected. Apple did change the automatic verification process.
Thank you, @sorentoft and my apologies to @vinceyuan. I will now delete the pull request because it's not relevant any more. The only way is to completely remove the uniqueIdentifier call.

@Zhukn1 Zhukn1 closed this Aug 18, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment