Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loader mods sorting by version not using SemVer or sorting by the version order #2762

Closed
maruohon opened this issue Jul 22, 2019 · 7 comments
Closed
Labels

Comments

@maruohon
Copy link

@maruohon maruohon commented Jul 22, 2019

System Information

MultiMC version: 0.6.6-1341
Operating System: Win 10

Summary of the suggestion:

The Loader Mods mod list sorting should consider the mod versions as following semver, when possible, and sort them according to the version number, instead of considering the version to be a string. As far as I can tell, currently the versions are sorted alphabetically/lexicographically whatever the correct term is. Also it seems that certain long version numbers get cut out, perhaps for being too long?

Screenshots:

Here is an example where 0.9.x and 0.10.x versions get sorted in an undesired order, and the longer date and timestamp based dev build versions get truncated completely. I believe these are still following the SemVer standard, although they are a bit unconventional for version numbers...
multimc_mod_sorting

@peterix
Copy link
Member

@peterix peterix commented Jul 27, 2019

Sounds reasonable :)

Loading

peterix added a commit that referenced this issue Jul 29, 2019
Sorting by version understands version numbers
Sorting by name removes 'The' prefixes before sorting
@peterix peterix closed this Jul 29, 2019
@Siphalor
Copy link

@Siphalor Siphalor commented Jul 30, 2019

Still doesn't work for me:

image

Version: 0.6.6-develop-1361

Loading

@peterix
Copy link
Member

@peterix peterix commented Jul 30, 2019

Looks sorted to me.

Loading

@Siphalor
Copy link

@Siphalor Siphalor commented Jul 30, 2019

Sorry, you’re right. I was just used that the mods were sorted oldest to newest before and totally messed up 🙂

Loading

@peterix
Copy link
Member

@peterix peterix commented Jul 30, 2019

Like, it's probably not semver, but it's at least trying now :)

Loading

@Siphalor
Copy link

@Siphalor Siphalor commented Jul 30, 2019

Seems like I uploaded the wrong image. It's still bugged:

image

Loading

@peterix
Copy link
Member

@peterix peterix commented Jul 30, 2019

Alright. Added more improvements along with #2550. Should be pretty good now, except for the lack of caching and slow refreshes.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants