Skip to content
Permalink
Browse files

NOISSUE Renaming for better understanding

  • Loading branch information...
Janrupf committed Jun 23, 2019
1 parent 306b98e commit b5a16935b75457ed3c34c0f83fe44310ad625cef
Showing with 5 additions and 5 deletions.
  1. +1 −1 api/logic/InstanceList.cpp
  2. +1 −1 api/logic/InstanceList.h
  3. +2 −2 application/MainWindow.cpp
  4. +1 −1 application/MainWindow.h
@@ -819,7 +819,7 @@ bool InstanceList::commitStagedInstance(const QString& path, const QString& inst
instanceSet.insert(instID);
m_groups.insert(groupName);
emit instancesChanged();
emit instanceAdded(instID);
emit instanceSelectRequest(instID);
}
saveGroupList();
return true;
@@ -129,7 +129,7 @@ class MULTIMC_LOGIC_EXPORT InstanceList : public QAbstractListModel
signals:
void dataIsInvalid();
void instancesChanged();
void instanceAdded(QString instanceId);
void instanceSelectRequest(QString instanceId);
void groupsChanged(QSet<QString> groups);

public slots:
@@ -703,7 +703,7 @@ MainWindow::MainWindow(QWidget *parent) : QMainWindow(parent), ui(new MainWindow
connect(MMC->instances().get(), &InstanceList::dataIsInvalid, this, &MainWindow::selectionBad);

// handle newly added instances
connect(MMC->instances().get(), &InstanceList::instanceAdded, this, &MainWindow::instanceAdded);
connect(MMC->instances().get(), &InstanceList::instanceSelectRequest, this, &MainWindow::instanceSelectRequest);

// When the global settings page closes, we want to know about it and update our state
connect(MMC, &MultiMC::globalSettingsClosed, this, &MainWindow::globalSettingsClosed);
@@ -1839,7 +1839,7 @@ void MainWindow::instanceChanged(const QModelIndex &current, const QModelIndex &
}
}

void MainWindow::instanceAdded(QString id)
void MainWindow::instanceSelectRequest(QString id)
{
setSelectedInstanceById(id);
}
@@ -152,7 +152,7 @@ private slots:

void instanceChanged(const QModelIndex &current, const QModelIndex &previous);

void instanceAdded(QString id);
void instanceSelectRequest(QString id);

void instanceDataChanged(const QModelIndex &topLeft, const QModelIndex &bottomRight);

0 comments on commit b5a1693

Please sign in to comment.
You can’t perform that action at this time.