Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Auto-gray Permgen option for Java 8+ or allow individual activation of each memory option #1552

Open
kotoroshinoto opened this Issue Apr 22, 2016 · 12 comments

Comments

Projects
None yet
4 participants
@kotoroshinoto
Copy link

kotoroshinoto commented Apr 22, 2016

new versions of java don't HAVE a permgen option anymore, and the VM puts a complaint when you supply it. No harm done, its more of an extremely minor irritation than anything super important..

Also wouldn't hurt to have an advanced panel with some of the other memory options, and some more common garbage collector and thread model options in a checklist.

Obviously that is achievable already with the arguments box, but it'd be neat.

@BobGamer455

This comment has been minimized.

Copy link

BobGamer455 commented May 20, 2016

I second this

@jikuja

This comment has been minimized.

Copy link

jikuja commented May 20, 2016

Also note that java 9 will exit and print error message if -XX:MaxPermSize or -XX:PermSize are used. Which makes this more then minor at some point in the future.

Am I confused with my reactions? Yes, there is no need to post +1 messages anymore. Just use correct reaction.

@peterix

This comment has been minimized.

Copy link
Member

peterix commented May 20, 2016

Just don't touch the option and it won't be passed to java at all.

@kotoroshinoto

This comment has been minimized.

Copy link
Author

kotoroshinoto commented May 20, 2016

its being passed in my instances, I do set the memory options, if need be, put that one under the control of a separate checkbox.

@peterix

This comment has been minimized.

Copy link
Member

peterix commented May 20, 2016

No. If permgen is set to 64, it is not passed.

@kotoroshinoto

This comment has been minimized.

Copy link
Author

kotoroshinoto commented May 20, 2016

that is a REALLY awkward method to control it, nonobvious to a general user who might want to edit their values.

@peterix

This comment has been minimized.

Copy link
Member

peterix commented May 20, 2016

permgen will eventually be forgotten... and I want to completely change how the game is launched. So any effort put into this right now is IMHO wasted.

@kotoroshinoto

This comment has been minimized.

Copy link
Author

kotoroshinoto commented May 20, 2016

well if the system is going to be redesigned anyway, this issue will be resolved.

Perhaps you could insert a tooltip or bit of text below the input box explaining that a value of 64 won't be passed, to allow users to avoid runtime complaints.

@kotoroshinoto

This comment has been minimized.

Copy link
Author

kotoroshinoto commented May 20, 2016

that'd be less complex than changing the launcher logic

@peterix

This comment has been minimized.

Copy link
Member

peterix commented May 20, 2016

The launcher logic simply has to change because of java 9, broken display drivers on windows, ability to run more than one instance, ability to run server instances, support for launch via java agent, disconnecting running instances from MultiMC so MultiMC can be closed and reopened while keeping track of what's running, and so on...

There is a LOT that has to be done with launching.

Not saying that it won't end up with some simple probe to disable that UI field anyway... but I'd rather work on the big changes first.

@kotoroshinoto

This comment has been minimized.

Copy link
Author

kotoroshinoto commented May 20, 2016

oh I know, I meant as a more immediate measure, as adding a textbox is considerably less invasive and doesn't have to change the logic at the moment.

@peterix

This comment has been minimized.

Copy link
Member

peterix commented Nov 21, 2018

This is not completely done. It's done only for the instance overrides.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.