New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all strings can be translated properly #1788

Closed
peterix opened this Issue Jan 17, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@peterix
Member

peterix commented Jan 17, 2017

Summary of the issue or suggestion:

MultiMC 0.5.0 includes some new strings. For example:
https://github.com/MultiMC/MultiMC5/blob/develop/application/setupwizard/AnalyticsWizardPage.cpp#L67

But this is nowhere to be found in the newly generated translation templates:
https://github.com/MultiMC/MultiMC5-translate/blob/master/template.pot (search for AnalyticsWizardPage)

What should happen:

All strings should be available for translation.

Suspected cause:

QApplication::translate is not recognized by the tools, while QObject::tr is.

peterix added a commit that referenced this issue Jan 17, 2017

@peterix

This comment has been minimized.

Member

peterix commented Jan 17, 2017

Converted everything into QObject::tr.

peterix added a commit that referenced this issue Jan 17, 2017

@peterix peterix closed this Jan 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment