New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System theme on macOS has wrong background colors in dialogs #1790

Open
peterix opened this Issue Jan 18, 2017 · 3 comments

Comments

Projects
None yet
1 participant
@peterix
Member

peterix commented Jan 18, 2017

System Information

MultiMC version: 0.5.0

Operating System: macOS

Summary of the issue or suggestion:

It's oddly greyish-brown instead of the expected color.

What should happen:

It looks right.

Suspected cause:

Resetting the default palette, Qt bug.

Additional Info:

This cannot be fully fixed. Only masked away.

Qt bug will have to be filed, because the documentation lies about resetting the palette after setting the style:
http://doc.qt.io/qt-5/qapplication.html#setStyle

When switching application styles, the color palette is set back to the initial colors or the system defaults. This is necessary since certain styles have to adapt the color palette to be fully style-guide compliant.

The palette is never reset.

@peterix

This comment has been minimized.

Member

peterix commented Jan 18, 2017

peterix added a commit that referenced this issue Jan 18, 2017

GH-1790 do not apply system theme on launch if it is selected
This prevents some ugly colors to show up on macOS in most cases.
It still looks ugly right after you switch to the it though.
@peterix

This comment has been minimized.

Member

peterix commented Jan 18, 2017

Reported upstream, no actionable tasks remain here.

Upstream bug: https://bugreports.qt.io/browse/QTBUG-58268

@peterix

This comment has been minimized.

Member

peterix commented Dec 11, 2018

TODO: minimal reproduction scenario.

@peterix peterix self-assigned this Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment