New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many empty lines in log when the log control is re-populated from the model #1802

Closed
peterix opened this Issue Jan 23, 2017 · 2 comments

Comments

Projects
None yet
1 participant
@peterix
Member

peterix commented Jan 23, 2017

System Information

MultiMC version: 0.5.0

Operating System: any

Summary of the issue or suggestion:

WTTS

Suspected cause:

It seems that the data structure used to store log lines doesn't work as it should, when the log grows beyond the original limits.

Test it manually.

If it's broken:

  • Fix it
  • Add unit tests to the model to make sure it never appears again
@peterix

This comment has been minimized.

Member

peterix commented Jan 23, 2017

This could be related to #1800

peterix added a commit that referenced this issue Feb 8, 2017

GH-1802 fix log resize handling
The log could end up with many empty lines because the wrong maximum size was
used during the resize.
@peterix

This comment has been minimized.

Member

peterix commented Feb 8, 2017

Not related to #1800

@peterix peterix closed this Feb 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment