New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad User Practice Can Lead to MultiMC Crash #1854

Closed
flcmc opened this Issue Apr 13, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@flcmc
Contributor

flcmc commented Apr 13, 2017

System Information

MultiMC version: 0.5.0-develop-950

Operating System: Windows

Summary of the issue or suggestion:

MultiMC completely crashes when the user tries to kill an instance that has already been terminated.

When killing an instance, MultiMC should check if the instance is still open.

This may also be an issue when the user tries to kill a frozen instance that closes before confirmation of killing the instance.

What should happen:

Nothing should happen when user tries to kill the instance.

Steps to reproduce the issue (Add more if needed):

  1. Launch any instance

  2. Press the Kill button, but don't actually confirm it.

  3. Close Minecraft.

  4. Go back to the MultiMC console and confirm killing the instance.

Suspected cause:

MultiMC doesn't check if the instance is already closed.

Logs/Screenshots:

No Logs, MultiMC simply crashes.

@peterix

This comment has been minimized.

Member

peterix commented Apr 13, 2017

Good one. There's likely a lot of those around.

Mostly it's caused by a less rigid UI and allowing people to do more things at the same time than before.

peterix added a commit that referenced this issue Apr 14, 2017

@peterix

This comment has been minimized.

Member

peterix commented Apr 14, 2017

Should be fixed in develop.

@peterix peterix closed this Apr 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment