New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instance twice launched after Update #1874

Closed
Zocker1999NET opened this Issue Apr 30, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@Zocker1999NET

Zocker1999NET commented Apr 30, 2017

System Information

MultiMC version: 0.5.0-develop-973

Operating System: Windows 10 Pro - Build 16184.1001

Summary of the issue:

When starting MultiMC with the launch command -l [instance], it searches also for updates and asks to install these when MultiMC found a newer version. After pressing Okay, MultiMC updates and starts itself again with the same launch command. After a few seconds, two MultiMC instances seem to run. Also two windows of the same game instance appear at the same time.

What should happen:

The old version of MultiMC should be closed and the game should only be started if the user has canceled the update or the update has finished.

Steps to reproduce the issue:

(Does only work if an update is available)

  1. Open a command line or create a link to MultiMC with the following line:
    MultiMC.exe -l myInstance
  2. Start MultiMC
  3. MultiMC asks for an update to install, accept the installation.
    MultiMC installs the update and starts itself with the same parameters.
    After a few seconds, you see in the taskbar that two windows of MultiMC are opened. And even a few moments later, two instances of Minecraft appear.

Suspected cause:

The game is started before the update window appears.

@flcmc

This comment has been minimized.

Contributor

flcmc commented May 1, 2017

I cannot reproduce this, a second MultiMC process is opened with the new version and the old MultiMC process is still open, but it doesn't open the instance again on the new one.

Still a problem however.

@peterix peterix added the multimc: bug label May 1, 2017

@peterix

This comment has been minimized.

Member

peterix commented May 1, 2017

  1. It shouldn't be launching the instance the second time (by the updated version).
  2. The update shouldn't be able to trigger with instances running.
@peterix

This comment has been minimized.

Member

peterix commented May 1, 2017

The changes in #1873 make it impossible to trigger updates while using -l $ID alone, because no main window is created anymore.

You can still have one open additionally afterwards. You can also have an existing one.

I'm adding a filter to the updater that will make it not launch the new process with -l $ID.
You can still trigger an update while an instance is running... so I will block that.
I will also block starting instances while an update is running.

That should fix all of {#1873, #1874, #1875}

peterix added a commit that referenced this issue May 1, 2017

peterix added a commit that referenced this issue May 1, 2017

GH-1874 do not allow updating while an instance is running
This is a nasty hack. Proper solution will require moving all
update related functionality out of the main window.

Running instances and updating should be mutually exclusive.

peterix added a commit that referenced this issue May 2, 2017

@peterix

This comment has been minimized.

Member

peterix commented May 2, 2017

MultiMC will now exit after an instance is closed, as long as there are no windows left behind.
It will not create a main window, unless you actually launch it normally.
Direct launch of instance does not - by default - not create an instance window. This has to be enabled in the settings, or the instance has to crash.

I consider this a good enough solution until MultiMC can track running instances even through its own restart.

Closing {#1873, #1874, #1875}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment