Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging and dropping a modpack zip into MultiMC from explorer resulted in explorer hanging for some time #2252

Open
anpilley opened this Issue Apr 22, 2018 · 12 comments

Comments

Projects
None yet
4 participants
@anpilley
Copy link

anpilley commented Apr 22, 2018

System Information

MultiMC version: 0.6.2-develop-1221

Operating System: Win10 16299.371

Summary of the issue or suggestion:

MultiMC supports dragging and dropping zipped up modpacks into its window to start the Add Instance process. Doing this from an explorer window hangs the explorer window until the import is complete, at which point, the explorer window becomes responsive again.

What should happen:

Explorer should remain responsive to user input.

Steps to reproduce the issue (Add more if needed):

  1. Download a larger modpack from curseforge.com (I was using Sevtech).

  2. Locate the modpack zip file in explorer.

  3. Drag the modpack into the MultiMC window.

  4. Attempt to interact with the originating explorer window.

Suspected cause:

Likely, the code stemming from

bool ModList::installMod(const QString &filename)

needs to be modified to queue up an import action, and then return to the drag/drop caller as quickly as possible, to release the drag&drop operation on Explorer's side.

Logs/Screenshots:

Additional Info:

@peterix

This comment has been minimized.

Copy link
Member

peterix commented Apr 22, 2018

Makes sense.

peterix added a commit to peterix/MultiMC5 that referenced this issue Apr 23, 2018

MultiMCGH-2252 make URL drop signal use a queued connection instead o…
…f direct call

Hopefully this will fix the issues with stuck applications on Windows.
@peterix

This comment has been minimized.

Copy link
Member

peterix commented Apr 23, 2018

Fixed in develop (AFAIK)

@peterix peterix closed this Apr 23, 2018

@anpilley

This comment has been minimized.

Copy link
Author

anpilley commented Apr 23, 2018

Yep, picked up the new build this morning, no more problems with explorer being unresponsive. Nice.

@peterix

This comment has been minimized.

Copy link
Member

peterix commented Apr 23, 2018

Glad to hear it. This was way worse with drag&drop of URLs from the browser :)

@Zekken01

This comment has been minimized.

Copy link

Zekken01 commented Apr 23, 2018

Does this also fix the issue with chrome?

@peterix

This comment has been minimized.

Copy link
Member

peterix commented Apr 23, 2018

I believe so. I tested it on Windows 7 and the problem was gone.

@Zekken01

This comment has been minimized.

Copy link

Zekken01 commented Apr 23, 2018

I can confirm fixed, I believe there may still be open issues related to this.

@swoolcock

This comment has been minimized.

Copy link

swoolcock commented Apr 25, 2018

Note that Finder in macOS has the same freezing issue, but this change does not fix it.

@peterix

This comment has been minimized.

Copy link
Member

peterix commented Apr 26, 2018

@swoolcock are you sure you are using the develop builds when testing this?

@swoolcock

This comment has been minimized.

Copy link

swoolcock commented Apr 27, 2018

Yes, using the latest develop build.

@peterix peterix reopened this Apr 27, 2018

@peterix

This comment has been minimized.

Copy link
Member

peterix commented Apr 27, 2018

OK... needs further investigation.

@anpilley

This comment has been minimized.

Copy link
Author

anpilley commented Apr 27, 2018

Yep. Can confirm it’s fixed on windows but not on my MacBook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.