Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging a mod with the same filename into the Mods screen doesn't replace the existing copy #2384

Closed
quat1024 opened this Issue Aug 23, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@quat1024
Copy link

quat1024 commented Aug 23, 2018

System Information

MultiMC version: 0.6.2-develop-1245 on win32

Operating System: Windows 7

Summary of the issue or suggestion:

When clicking and dragging a mod file into the Loader Mods list, when a mod already exists with the same filename, nothing happens.

What should happen:

I'd love it if the newly dragged-in copy would replace the old one!

Steps to reproduce the issue (Add more if needed):

  1. Procure some mod jar file, and click-drag it into the Loader Mods list.

  2. Change the contents of it, but give it the same name.

  3. Drag the new file into the Loader Mods list.

  4. Nothing happens (the old file is still in your instance folder)

Suspected cause:

Fairy gremlins

Logs/Screenshots:

Nothing out of the ordinary.

Additional Info:

This would be great for mod development - I manage my (outside-dev environment) test instances with MultiMC, and it would be nice to update the copy of a mod in my instance without having to View Folder and fiddle with files manually. The version number doesn't always change, meaning the mod's filename isn't always different.

Just a little thing.

@Janrupf

This comment has been minimized.

Copy link
Contributor

Janrupf commented Aug 24, 2018

Confirmed.

@peterix

This comment has been minimized.

Copy link
Member

peterix commented Aug 30, 2018

Sounds bug-like to me.

Janrupf added a commit to Janrupf/MultiMC5 that referenced this issue Nov 9, 2018

peterix added a commit that referenced this issue Nov 12, 2018

peterix added a commit that referenced this issue Nov 12, 2018

GH-2384 when adding mods with the same filename, rotate the files
Current will be disabled and renamed to '$name-old'.
Old one, if present, will be removed.
@peterix

This comment has been minimized.

Copy link
Member

peterix commented Nov 21, 2018

Fixed in develop.

@peterix peterix closed this Nov 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.