Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Columns in Versions page seem to allow sorting while they shouldn't #2467

Closed
africalinguist opened this Issue Nov 20, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@africalinguist
Copy link

africalinguist commented Nov 20, 2018

System Information

MultiMC version: 0.6.2-develop-1176

Operating System: Ubuntu 18.04

Summary of the issue or suggestion:

When you click any of the buttons for sorting the list of items in the "Version" tab of the edit instance window nothing happens to the list.

What should happen:

It should sort the items based on name or version, depending on which button you clicked.

Steps to reproduce the issue (Add more if needed):

  1. Select an instance

  2. click "Edit Instance"

  3. go to the "Version" tab

  4. click either of the buttons that should sort the list

Suspected cause:

not sure

Logs/Screenshots:

multimc sorted one way
multimc sorted the other way

Additional Info:

@peterix

This comment has been minimized.

Copy link
Member

peterix commented Nov 20, 2018

The order is significant and affects how the game is launched. Sorting these is a potentionally destructive action if you don't remember the correct order.

Real issue is that the UI element appears to allow it.

@peterix peterix changed the title Versions sorting buttons aren't working Columns in Versions page seem to allow sorting while they shouldn't Nov 20, 2018

peterix added a commit that referenced this issue Nov 20, 2018

@peterix

This comment has been minimized.

Copy link
Member

peterix commented Nov 20, 2018

Should be fixed in next dev build.

@peterix peterix closed this Nov 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.