Pangolin: update for v4: add QC note, update tool versions columns #2157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladsavelyev
force-pushed
the
pangolinQc
branch
from
3da705d to
b951ac3
Compare
vladsavelyev
reviewed
Nov 5, 2023
vladsavelyev
reviewed
Nov 5, 2023
vladsavelyev
reviewed
Nov 5, 2023
vladsavelyev
reviewed
Nov 5, 2023
vladsavelyev
requested changes
Nov 5, 2023
Member
vladsavelyev
left a comment
vladsavelyev
left a comment
There was a problem hiding this comment.
The QC notes addition looks good, but would be good to add some comment justifying the version reporting
vladsavelyev
changed the title
vladsavelyev
approved these changes
Nov 6, 2023
Member
|
@multiqc-bot changelog |
vladsavelyev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdhas been updatedHi @ewels and team! This PR:
constellationsandscorpio(used by Pangolin since v4) instead ofPangoLEARNandpango(used by older versions).I did run the MultiQC test data through and it all passed and looked good.
Thanks for your consideration!