From 9186da0bd1fbf5e11b905fd4888a760d0274cb8b Mon Sep 17 00:00:00 2001 From: Henry Webel Date: Fri, 21 Mar 2025 09:29:21 +0100 Subject: [PATCH 1/3] :bug: environment variable access in powershell --- .github/workflows/cdci.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/cdci.yml b/.github/workflows/cdci.yml index 040b3d0..e406d22 100644 --- a/.github/workflows/cdci.yml +++ b/.github/workflows/cdci.yml @@ -183,12 +183,14 @@ jobs: gh release upload $GITHUB_REF_NAME vuegen_gui_${{ matrix.os.label }}.zip # .app is folder that needs to be zipped - name: Upload Windows Executable to a GitHub Release - if: startsWith(matrix.os.runner, 'windows') && startsWith(github.ref, 'refs/tags') + if: startsWith(matrix.os.runner, 'windows') env: GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | - echo GITHUB_REF_NAME $GITHUB_REF_NAME - echo "Uploading vuegen_gui_${{ matrix.os.label }} to release $GITHUB_REF_NAME" + echo env:GITHUB_REF_NAME $env:$GITHUB_REF_NAME + $GITHUB_REF_NAME = $env:$GITHUB_REF_NAME + echo "Uploading vuegen_gui_${{ matrix.os.label }} to release $GITHUB_REF_NAME" + $GITHUB_REF_NAME = 'v0.3.0-beta' echo "Available files in build folder: gui/dist/" ls gui/dist/ echo "Uploading..." From 87b3c9c0412795552b76552676fc74b894f2ee3a Mon Sep 17 00:00:00 2001 From: Henry Webel Date: Fri, 21 Mar 2025 11:29:28 +0100 Subject: [PATCH 2/3] :bug: remove $ sign after $env: for powershell --- .github/workflows/cdci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/cdci.yml b/.github/workflows/cdci.yml index e406d22..96c282a 100644 --- a/.github/workflows/cdci.yml +++ b/.github/workflows/cdci.yml @@ -187,8 +187,8 @@ jobs: env: GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | - echo env:GITHUB_REF_NAME $env:$GITHUB_REF_NAME - $GITHUB_REF_NAME = $env:$GITHUB_REF_NAME + echo GITHUB_REF_NAME in env $env:GITHUB_REF_NAME + $GITHUB_REF_NAME = $env:GITHUB_REF_NAME echo "Uploading vuegen_gui_${{ matrix.os.label }} to release $GITHUB_REF_NAME" $GITHUB_REF_NAME = 'v0.3.0-beta' echo "Available files in build folder: gui/dist/" From 87196604a5b198b943f977770679da860cda703b Mon Sep 17 00:00:00 2001 From: Henry Webel Date: Fri, 21 Mar 2025 12:20:26 +0100 Subject: [PATCH 3/3] :art: one-liner, remove hard-coded tag for testing --- .github/workflows/cdci.yml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/cdci.yml b/.github/workflows/cdci.yml index 96c282a..b21d669 100644 --- a/.github/workflows/cdci.yml +++ b/.github/workflows/cdci.yml @@ -183,14 +183,13 @@ jobs: gh release upload $GITHUB_REF_NAME vuegen_gui_${{ matrix.os.label }}.zip # .app is folder that needs to be zipped - name: Upload Windows Executable to a GitHub Release - if: startsWith(matrix.os.runner, 'windows') + if: startsWith(matrix.os.runner, 'windows') && startsWith(github.ref, 'refs/tags') env: GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | - echo GITHUB_REF_NAME in env $env:GITHUB_REF_NAME + echo "GITHUB_REF_NAME in env $env:GITHUB_REF_NAME" $GITHUB_REF_NAME = $env:GITHUB_REF_NAME - echo "Uploading vuegen_gui_${{ matrix.os.label }} to release $GITHUB_REF_NAME" - $GITHUB_REF_NAME = 'v0.3.0-beta' + echo "Uploading vuegen_gui_${{ matrix.os.label }} to release $GITHUB_REF_NAME" echo "Available files in build folder: gui/dist/" ls gui/dist/ echo "Uploading..."