New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inital extra bed commit with back-compatibility #1070
Inital extra bed commit with back-compatibility #1070
Conversation
Needs review and permissions advice before continuing. line ending derp
Your formatting is kinda ... fucked up. But I like the idea. |
what style guidelines does multiverse follow? |
We generally follow the same guidelines as bukkit, but that shouldn't matter a lot, we can just pull the request, run it through the autoformatter and be done with it. Summary: 4 spaces, spaces in places that make sense (see my comments on the message). |
Should I have added unit tests for this? What permissions should be set up for this? mv.tp.self.b would default to own bed. does there need to be an additional permission for teleporting to someone elses bed? |
# Auto detect text files and perform LF normalization | ||
* text=auto | ||
|
||
# Custom for Visual Studio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason for keeping anything after the auto-lf normalization rule? I mean, the rest of it wont really matter to a java repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
honestly the only reason this is even in the commit is github for windows wouldn't stop nagging about it, so i just said, yes fix it, this is what it added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never trust git GUIs. Things like this are exactly why I always commit and push from the command line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never trust git GUIs.
👍
Improved version: main--/Multiverse-Core@ce80fc1. |
Looks good to me, except maybe keep the auto lf change. Way too many people screw that up with PRs |
I need some advice on how to continue, mainly what I should be worried about when it comes to permissions, whether to bother with the backwards compatibility checks and if theres any side-effects.
I've been running this code on my server for a few weeks now and havn't run into any problems (except permissions) but I'm not a heavy multiverse user.
Sorry about travis.yml and the gitattributes but github for windows was complaining and I wasn't sure how to fix the line numbering anyway, I'll pull request another fixed version at some stage.