Skip to content

Initial support for lists of language strings #366

Open
wants to merge 6 commits into from

4 participants

@dumptruckman
Multiverse member

The default message providers still only returns one string, but it stores messages in a list.

@FernFerret
Multiverse member

I'll let @main-- handle this PR since localization is his baby.

@FernFerret
Multiverse member

Just want to make sure this doesn't get forgotten. @main-- thoughs?

@main--
Multiverse member
main-- commented Jan 5, 2012

We talked in IRC about this and I told @dumptruckman that I don't like the fact that String getMessage(MultiverseMessage) still exists. (In my opinion: Either only single strings or only string-lists). But there are some other nice additions in there. I'm going to merge parts of this PR tomorrow.

@main--
Multiverse member
main-- commented Jan 6, 2012

I squashed the commits a bit and pushed them to my fork. I think I'm going to cherry-pick main--/Multiverse-Core@1507b0d, improve it and push it.

@main--
Multiverse member
main-- commented Jan 6, 2012

Parts of this pull request were merged in 3e4b042.

@main--
Multiverse member
main-- commented Jan 6, 2012

But at the moment I don't think that I'm going to pull the multiline-feature. Lists make everything so complicated compared to single strings.

@FernFerret
Multiverse member

Just an FYI, the MVMessaging class supports lists. If that makes a difference, since everything should be moving in that direction.

@FernFerret
Multiverse member

Is this getting merged in a branch (/cc @main-- @dumptruckman )

@main--
Multiverse member
main-- commented Jan 19, 2012

Oh, I totally forgot about this pull request. I'm going to be away for some days, I'll handle it when I'm back.

@md-5
md-5 commented Sep 22, 2012

*crickets :P

@FernFerret
Multiverse member

Haha oh @md-5.

But seriously, where is the status of this?

@md-5
md-5 commented Oct 16, 2012

Oh. My. God. Its FernFerret!

@FernFerret
Multiverse member

Huzzah!

@dumptruckman
Multiverse member

I believe @main-- is working on proper localization.

@main--
Multiverse member
main-- commented Nov 5, 2012

I'm doing multi-line messages with \n's right now. I haven't tested it but it should work (see CraftBukkit's TextWrapper).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.