Initial support for lists of language strings #366

Open
wants to merge 6 commits into
from

Conversation

Projects
None yet
4 participants
@dumptruckman
Member

dumptruckman commented Jan 2, 2012

The default message providers still only returns one string, but it stores messages in a list.

@FernFerret

This comment has been minimized.

Show comment
Hide comment
@FernFerret

FernFerret Jan 2, 2012

Member

I'll let @main-- handle this PR since localization is his baby.

Member

FernFerret commented Jan 2, 2012

I'll let @main-- handle this PR since localization is his baby.

@FernFerret

This comment has been minimized.

Show comment
Hide comment
@FernFerret

FernFerret Jan 5, 2012

Member

Just want to make sure this doesn't get forgotten. @main-- thoughs?

Member

FernFerret commented Jan 5, 2012

Just want to make sure this doesn't get forgotten. @main-- thoughs?

@main--

This comment has been minimized.

Show comment
Hide comment
@main--

main-- Jan 5, 2012

Member

We talked in IRC about this and I told @dumptruckman that I don't like the fact that String getMessage(MultiverseMessage) still exists. (In my opinion: Either only single strings or only string-lists). But there are some other nice additions in there. I'm going to merge parts of this PR tomorrow.

Member

main-- commented Jan 5, 2012

We talked in IRC about this and I told @dumptruckman that I don't like the fact that String getMessage(MultiverseMessage) still exists. (In my opinion: Either only single strings or only string-lists). But there are some other nice additions in there. I'm going to merge parts of this PR tomorrow.

@main--

This comment has been minimized.

Show comment
Hide comment
@main--

main-- Jan 6, 2012

Member

I squashed the commits a bit and pushed them to my fork. I think I'm going to cherry-pick main--/Multiverse-Core@1507b0d, improve it and push it.

Member

main-- commented Jan 6, 2012

I squashed the commits a bit and pushed them to my fork. I think I'm going to cherry-pick main--/Multiverse-Core@1507b0d, improve it and push it.

@main--

This comment has been minimized.

Show comment
Hide comment
@main--

main-- Jan 6, 2012

Member

Parts of this pull request were merged in 3e4b042.

Member

main-- commented Jan 6, 2012

Parts of this pull request were merged in 3e4b042.

@main--

This comment has been minimized.

Show comment
Hide comment
@main--

main-- Jan 6, 2012

Member

But at the moment I don't think that I'm going to pull the multiline-feature. Lists make everything so complicated compared to single strings.

Member

main-- commented Jan 6, 2012

But at the moment I don't think that I'm going to pull the multiline-feature. Lists make everything so complicated compared to single strings.

@FernFerret

This comment has been minimized.

Show comment
Hide comment
@FernFerret

FernFerret Jan 6, 2012

Member

Just an FYI, the MVMessaging class supports lists. If that makes a difference, since everything should be moving in that direction.

Member

FernFerret commented Jan 6, 2012

Just an FYI, the MVMessaging class supports lists. If that makes a difference, since everything should be moving in that direction.

@FernFerret

This comment has been minimized.

Show comment
Hide comment
@FernFerret

FernFerret Jan 19, 2012

Member

Is this getting merged in a branch (/cc @main-- @dumptruckman )

Member

FernFerret commented Jan 19, 2012

Is this getting merged in a branch (/cc @main-- @dumptruckman )

@main--

This comment has been minimized.

Show comment
Hide comment
@main--

main-- Jan 19, 2012

Member

Oh, I totally forgot about this pull request. I'm going to be away for some days, I'll handle it when I'm back.

Member

main-- commented Jan 19, 2012

Oh, I totally forgot about this pull request. I'm going to be away for some days, I'll handle it when I'm back.

@md-5

This comment has been minimized.

Show comment
Hide comment
@md-5

md-5 Sep 22, 2012

*crickets :P

md-5 commented Sep 22, 2012

*crickets :P

@FernFerret

This comment has been minimized.

Show comment
Hide comment
@FernFerret

FernFerret Oct 16, 2012

Member

Haha oh @md-5.

But seriously, where is the status of this?

Member

FernFerret commented Oct 16, 2012

Haha oh @md-5.

But seriously, where is the status of this?

@md-5

This comment has been minimized.

Show comment
Hide comment
@md-5

md-5 Oct 16, 2012

Oh. My. God. Its FernFerret!

md-5 commented Oct 16, 2012

Oh. My. God. Its FernFerret!

@FernFerret

This comment has been minimized.

Show comment
Hide comment
@FernFerret

FernFerret Oct 16, 2012

Member

Huzzah!

Member

FernFerret commented Oct 16, 2012

Huzzah!

@dumptruckman

This comment has been minimized.

Show comment
Hide comment
@dumptruckman

dumptruckman Nov 5, 2012

Member

I believe @main-- is working on proper localization.

Member

dumptruckman commented Nov 5, 2012

I believe @main-- is working on proper localization.

@main--

This comment has been minimized.

Show comment
Hide comment
@main--

main-- Nov 5, 2012

Member

I'm doing multi-line messages with \n's right now. I haven't tested it but it should work (see CraftBukkit's TextWrapper).

Member

main-- commented Nov 5, 2012

I'm doing multi-line messages with \n's right now. I haven't tested it but it should work (see CraftBukkit's TextWrapper).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment