Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double input of a Staticman parameter #237

Closed
VincentTam opened this issue Jul 12, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@VincentTam
Copy link

commented Jul 12, 2019

In #224, Hugo's cache has been introduced so that user only needs to input reCAPTCHA parameters only once in the Staticman config file.

{{- $reCaptcha := $staticman.comments.reCaptcha | default ( dict "enabled" false ) -}}

Nonetheless, users have to input the branch twice, once in the theme config file and once in the Staticman config file. A little line like

{{- $branch := $staticman.comments.branch -}}

would make the whole thing consistent with your arguments for calling parameters from the Staticman config file.

MunifTanjim added a commit that referenced this issue Jul 12, 2019

@MunifTanjim

This comment has been minimized.

Copy link
Owner

commented Jul 12, 2019

@VincentTam check the latest commit: 4eb4160

@VincentTam

This comment has been minimized.

Copy link
Author

commented Jul 12, 2019

Thanks for commit.

@VincentTam VincentTam closed this Jul 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.