Remove accept, request, and borrow versions #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These functions aren't used any more, confuse users and clutter the namespace. All occurences of code like ```rust let (tx, rx) = channel(); let t1 = spawn(move || srv(accept(tx).unwrap())); let t2 = spawn(move || cli(request(rx).unwrap())); ``` can be replaced by the shorter and nicer ```rust let (c1, c2) = session_channel(); let t1 = spawn(move || srv(c1)); let t2 = spawn(move || cli(c2)); ``` For the tests to still pass, we need to remove the issue-8 compile-fail test, which tested against a soundness bug in request.
|
This fails because the compile-fail directory does not exist when empty. I'll add a basic compile-fail test. |
|
We could use more of those anyway, to showcase what our library does. |
|
#21 will try to add some more tests. |
|
@laumann: r? |
|
r+ |
Munksgaard
added a commit
that referenced
this pull request
Jul 28, 2015
Remove accept, request, and borrow versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions aren't used any more, confuse users and clutter the
namespace.
All occurences of code like
can be replaced by the shorter and nicer
For the tests to still pass, we need to remove the issue-8 compile-fail
test, which tested against a soundness bug in request.