Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player have other PlayerVault #53

Closed
ghost opened this issue Mar 10, 2018 · 9 comments
Closed

Player have other PlayerVault #53

ghost opened this issue Mar 10, 2018 · 9 comments
Labels

Comments

@ghost
Copy link

ghost commented Mar 10, 2018

Everyone always gets a random playervault.

@Muqsit
Copy link
Owner

Muqsit commented Mar 11, 2018

Aside from being a vague description, I can't reproduce this while having 25 slappers spam /pv 1. Feel free to ping back though.

@Muqsit Muqsit closed this as completed Mar 11, 2018
@iZeaoGamer
Copy link

I have the same issue as well. I've deleted the plugin until this get's fixed.

@iZeaoGamer
Copy link

How about test it on your test server, and let me know if you have this issue, @Muqsit.

@Matthww
Copy link

Matthww commented Apr 1, 2018

I'm getting the same issue aswell. I'm using mysql if that makes any difference.

When I tried to do /pv 1 is saw random items from other people their pv, I could steal it and sometime theirs even gets cleared and mine gets cleared aswell.

@Muqsit
Copy link
Owner

Muqsit commented Apr 2, 2018

Can you test this phar file? A bug was fixed in InvMenu regarding this somewhat. I still can't get to reproduce this bug so I can't say for sure. It would be nice if someone gets to record this.

I've tried spam-calling InvMenu::send() in an attempt to get my inventory mixed with someone else's with 30 slappers online and yet couldn't get it to happen. Maybe our builds differ?

@iZeaoGamer
Copy link

The latest poggit build, or?

@fycarman
Copy link

fycarman commented Apr 2, 2018

@Muqsit the issue still exist, steps to reproduce:

  • join the server
  • ask a friend to join the server
  • open your pv (I use to open the first), don't put anything inside.
  • ask your friend to open his pv, he doesn't have to put anything inside.
  • ask your friend to re-open his pv and put something.
  • re-open your pv, and put something.
  • ask your friend to re-open his pv, now he will see your pv.

@Muqsit Muqsit reopened this Apr 2, 2018
@Muqsit Muqsit added the bug label Apr 2, 2018
Muqsit added a commit to Muqsit/InvMenu that referenced this issue Apr 2, 2018
@Muqsit Muqsit closed this as completed in 20c7017 Apr 2, 2018
@Muqsit
Copy link
Owner

Muqsit commented Apr 2, 2018

The latest phar is here: https://poggit.pmmp.io/r/26999/PlayerVaults_dev-28.phar
That should fix it.

@isoz
Copy link

isoz commented Apr 5, 2018

I'm still getting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants