Skip to content

Commit

Permalink
Upgrade to Angular 6
Browse files Browse the repository at this point in the history
  • Loading branch information
MurhafSousli committed May 4, 2018
1 parent 4052d9b commit b01fa0d
Show file tree
Hide file tree
Showing 138 changed files with 9,543 additions and 9,745 deletions.
60 changes: 0 additions & 60 deletions .angular-cli.json

This file was deleted.

14 changes: 0 additions & 14 deletions .config/build.js

This file was deleted.

11 changes: 0 additions & 11 deletions .config/publish.js

This file was deleted.

6 changes: 1 addition & 5 deletions .gitignore
Expand Up @@ -2,7 +2,6 @@

# compiled output
/dist
/build
/tmp
/out-tsc

Expand Down Expand Up @@ -31,13 +30,10 @@
/coverage
/libpeerconnection.log
npm-debug.log
yarn-error.log
testem.log
/typings

# e2e
/e2e/*.js
/e2e/*.map

# System Files
.DS_Store
Thumbs.db
17 changes: 0 additions & 17 deletions .npmignore

This file was deleted.

58 changes: 31 additions & 27 deletions CONTRIBUTING.md
@@ -1,53 +1,57 @@
# Contributing

Here are the instructions on how to develop locally:

### 1. Clone the repo

```bash
$ git clone https://github.com/MurhafSousli/ngx-progressbar.git
$ git clone https://github.com/MurhafSousli/ngx-progressbar.git && cd ngx-progressbar
```

### 2. Install the dependencies

Go inside the repo folder
NPM

```bash
$ npm install
```
$ npm install
```

### 3. Build the core package first
YARN

The are 3 packages
```
$ yarn install
```

### 3. Building

The are 3 packages

- **@ngx-progressbar/core** no dependencies
- **@ngx-progressbar/http** depends on core
- **@ngx-progressbar/router** depends on core
- **@ngx-progressbar/http** depended on the core package
- **@ngx-progressbar/router** depended on the core package

A. Build the core package using the command
**A. Build the core package**

```bash
npm run build-core
```
$ npm run build-core
```

Open to `core/build/package.json`, and replace `"VERSION"`, to valid version, e.g. `4.0.0`

B. Register it Link it
Then link the core, so you can build the other packages (needed only the first time)

```bash
npm link build/core
```
$ npm run link-core
```

Now **@ngx-progressbar/core** is linked, we can build the other packages without errors.
**B. Build the http package**

### 4. Make your changes
```
$ npm run build-http
```

Now the build setup should be working, make the changes. use the included demo app for testing
**C. Build the router package**

### 5. Build all the packages
```bash
npm run build-all
```
```
$ npm run build-router
```

***

### 6. Submit your PR
### 4. Submit your PR
8 changes: 4 additions & 4 deletions README.md
Expand Up @@ -7,13 +7,13 @@ A nanoscopic progress bar. Featuring realistic trickle animations to convince yo

___
[![npm](https://img.shields.io/badge/demo-online-ed1c46.svg)](https://murhafsousli.github.io/ngx-progressbar/)
[![npm](https://img.shields.io/npm/v/@ngx-progressbar/core.svg?maxAge=2592000?style=plastic)](https://www.npmjs.com/package/ngx-progressbar)
[![Build Status](https://travis-ci.org/MurhafSousli/ngx-progressbar.svg?branch=master)](https://www.npmjs.com/package/ngx-progressbar)
[![npm](https://img.shields.io/npm/l/express.svg?maxAge=2592000)](/LICENSE)
[![npm](https://img.shields.io/npm/v/@ngx-progressbar/core.svg?maxAge=2592000?style=plastic)](https://www.npmjs.com/package/@ngx-progressbar/core)
[![Build Status](https://travis-ci.org/MurhafSousli/ngx-progressbar.svg?branch=master)](https://travis-ci.org/MurhafSousli/ngx-progressbar)
[![npm](https://img.shields.io/npm/l/express.svg?maxAge=2592000)](https://github.com/MurhafSousli/ngx-progressbar/blob/master/LICENSE)

### Before you begin!

This is the documentation for **ngx-progressbar** version 4.x (Angular >= 5)
This is the documentation for **ngx-progressbar** version 4.x (Angular >= 5) and version 5.x (Angular >= 6)

- For **ngx-progressbar** version 3.x (Angular >= 5), See this [documentation](README_V3.md)
- For **ngx-progressbar** version 2.x (Angular 2 & 4), See this [documentation](https://github.com/MurhafSousli/ngx-progressbar/wiki)
Expand Down

0 comments on commit b01fa0d

Please sign in to comment.