New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidal plugin not working when curl input uses MaybeBufferedInputStream #346

Open
joerg-krause opened this Issue Aug 23, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@joerg-krause
Contributor

joerg-krause commented Aug 23, 2018

I've cross-compiled MPD git master branch for an embedded Linux device (i.MX6). Tidal plugin was working fine before using commit 66a1e8b. Git bisect showed that commit 1ca1269 introduced the issue.

This is the log running mpg-git 1ca1269:

# ./mpd --no-daemon --stderr --verbose /run/mpd/mpd.conf
config_file: loading file /run/mpd/mpd.conf
libsamplerate: libsamplerate converter 'Fastest Sinc Interpolator'
opus: libopus 1.2.1
sndfile: libsndfile-1.0.28
simple_db: reading DB
curl: version 7.61.0
curl: with OpenSSL/1.0.2o
state_file: Loading state file /var/lib/mpd/state
playlist: queue song 0:"tidal://track/70807417"
tidal: Sending login request
client: [0] opened from 127.0.0.1:41512
client: [0] process command "status"
client: [0] command returned 0
tidal: Login successful, session=9326729a-49f9-47dd-a009-f35143b4412a
tidal: Tidal track '70807417' resolves to http://ab-pr-ak.audio.tidal.com/334787f1c41838ad79f228c6a2b73d30_26.flac?__token__=exp=1535063885~hmac=d9704d0db74016fc71d853acf64531810006142bed0ddb9bc433babb2c2b18e8
decoder_thread: probing plugin flac
flac: FLAC__STREAM_DECODER_ERROR_STATUS_LOST_SYNC
flac: FLAC__STREAM_DECODER_ERROR_STATUS_LOST_SYNC
flac: FLAC__STREAM_DECODER_ERROR_STATUS_LOST_SYNC
flac: FLAC__STREAM_DECODER_ERROR_STATUS_LOST_SYNC
flac: FLAC__STREAM_DECODER_ERROR_STATUS_LOST_SYNC
flac: FLAC__STREAM_DECODER_ERROR_STATUS_LOST_SYNC
flac: FLAC__STREAM_DECODER_ERROR_STATUS_LOST_SYNC
flac: FLAC__STREAM_DECODER_ERROR_STATUS_LOST_SYNC
flac: FLAC__STREAM_DECODER_ERROR_STATUS_LOST_SYNC
flac: FLAC__STREAM_DECODER_ERROR_STATUS_LOST_SYNC
flac: FLAC__STREAM_DECODER_ERROR_STATUS_LOST_SYNC
flac: FLAC__STREAM_DECODER_ERROR_STATUS_LOST_SYNC
flac: FLAC__STREAM_DECODER_ERROR_STATUS_LOST_SYNC
flac: FLAC__STREAM_DECODER_ERROR_STATUS_LOST_SYNC
flac: FLAC__STREAM_DECODER_ERROR_STATUS_LOST_SYNC
flac: FLAC__STREAM_DECODER_ERROR_STATUS_LOST_SYNC
flac: FLAC__STREAM_DECODER_ERROR_STATUS_LOST_SYNC
flac: FLAC__STREAM_DECODER_ERROR_STATUS_LOST_SYNC
flac: FLAC__STREAM_DECODER_ERROR_STATUS_LOST_SYNC
flac: FLAC__STREAM_DECODER_ERROR_STATUS_LOST_SYNC
flac: FLAC__STREAM_DECODER_ERROR_STATUS_LOST_SYNC
flac: FLAC__STREAM_DECODER_ERROR_STATUS_LOST_SYNC
flac: FLAC__STREAM_DECODER_ERROR_STATUS_LOST_SYNC
flac: FLAC__STREAM_DECODER_ERROR_STATUS_LOST_SYNC
flac: FLAC__STREAM_DECODER_ERROR_STATUS_LOST_SYNC
flac: FLAC__STREAM_DECODER_ERROR_STATUS_LOST_SYNC
decoder_thread: probing plugin ffmpeg
client: [0] process command "status"
client: [0] command returned 0
client: [0] process command "currentsong"
client: [0] command returned 0
client: [0] process command "playlistinfo "1""
client: [0] command returned 0
exception: Failed to decode tidal://track/70807417
player: played "tidal://track/70807417"
playlist: stop

This is the log running mpd-git 66a1e8b:

# ./mpd --no-daemon --stderr --verbose /run/mpd/mpd.conf
config_file: loading file /run/mpd/mpd.conf
libsamplerate: libsamplerate converter 'Fastest Sinc Interpolator'
opus: libopus 1.2.1
sndfile: libsndfile-1.0.28
simple_db: reading DB
exception: Input plugin 'qobuz' is unavailable: No Qobuz app_id configured
curl: version 7.61.0
curl: with OpenSSL/1.0.2o
state_file: Loading state file /var/lib/mpd/state
playlist: queue song 0:"tidal://track/70807417"
client: [0] opened from 127.0.0.1:41438
client: [0] process command "status"
tidal: Sending login request
client: [0] command returned 0
client: [0] process command "currentsong"
client: [0] command returned 0
client: [1] opened from 127.0.0.1:41440
client: [2] opened from 127.0.0.1:41442
client: [1] process command "status"
client: [1] command returned 0
client: [0] closed
client: [2] process command "status"
client: [2] command returned 0
client: [2] process command "currentsong"
client: [2] command returned 0
client: [2] closed
tidal: Login successful, session=778f7cb8-dd2f-4c62-a56a-fcf26c40fd10
tidal: Tidal track '70807417' resolves to http://ab-pr-ak.audio.tidal.com/334787f1c41838ad79f228c6a2b73d30_26.flac?__token__=exp=1535063828~hmac=3e73658d270b6fa39b2801eb19ddc85dd869726c98b979762df9f2082b73152e
decoder_thread: probing plugin flac
decoder: audio_format=44100:16:2, seekable=true
client: [1] process command "status"
client: [1] command returned 0
client: [1] process command "currentsong"
client: [1] command returned 0
client: [1] process command "playlistinfo "1""
client: [1] command returned 0
client: [1] process command "playlistinfo"
client: [1] command returned 0
alsa_output: opened default type=PLUG
alsa_output: buffer: size=58..15052 time=1315..341316
alsa_output: period: size=29..7527 time=666..170667
alsa_output: default period_time = buffer_time/4 = 341315/4 = 85328
alsa_output: format=S16_LE (Signed 16 bit Little Endian)
alsa_output: buffer_size=15052 period_size=3763
output: opened "ALSA" (alsa) audio_format=44100:16:2

I am happy to to test and provide any information you need!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment