Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"list" command does not group when listing files #526

Open
tarcisioe opened this Issue Apr 5, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@tarcisioe
Copy link

tarcisioe commented Apr 5, 2019

Example: the command list file group date has the same output of list file. No dates are present, no grouping happens.

I was hoping to use list file "(artist = '...')" group date group album to easily create a list of every song by an artist in chronological order to add to the playlist. If there is a better way to do that, I would also like to know.

Unfortunately this along with #408 and the fact that list file <filter> group date outputs

[ARG/2@0] {list} Unknown filter type

makes this usecase seemingly impossible.

I could try to help in fixing this, but I believe I would need a better understanding of what the list command is actually supposed to do and if it really should behave differently for file.

@MaxKellermann

This comment has been minimized.

Copy link
Member

MaxKellermann commented Apr 5, 2019

There's the findadd command which can sort in MPD 0.22 (git).
A note about "chronological order": list does not sort. It returns an arbitrary order.
But what you pointed out indeed is a bug; the file parameter is a special case in the MPD code which does not implement group.

@tarcisioe

This comment has been minimized.

Copy link
Author

tarcisioe commented Apr 5, 2019

I see, grouping does not do sorting. I thought it would because it is a fairly straightforward way to group things. But can findadd sort by more than one criteria? And if it currently can't, would it be reasonable to add that feature? I could help with that.

@MaxKellermann

This comment has been minimized.

Copy link
Member

MaxKellermann commented Apr 5, 2019

It sorts by only one tag, but I'd welcome attempts to support multiple sort tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.