Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inotify registration ignores .mpdignore #846

Closed
madduck opened this issue Apr 29, 2020 · 0 comments
Closed

inotify registration ignores .mpdignore #846

madduck opened this issue Apr 29, 2020 · 0 comments
Labels
Milestone

Comments

@madduck
Copy link

madduck commented Apr 29, 2020

Bug report

Describe the bug

The auto_update inotify registration does not respect .mpdignore files.

% grep ^music_directory ~/.config/mpd/mpd.conf 
music_directory		"/media/kids"

% cat /media/kids/.mpdignore
lost+found

Expected Behavior

If I put a file/dir into .mpdignore, I expect it to not be scanned. Therefore, I don't expect an inotify hook to be registered.

Actual Behavior

The hook is being registered, and the logs spammed…

Version

Music Player Daemon 0.21.22 (0.21.22)
Copyright 2003-2007 Warren Dukes <warren.dukes@gmail.com>
Copyright 2008-2018 Max Kellermann <max.kellermann@gmail.com>
This is free software; see the source for copying conditions.  There is NO
warranty; not even MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Database plugins:
 simple proxy

Storage plugins:
 local smbclient nfs

Neighbor plugins:
 smbclient

Decoders plugins:
 [mad] mp3 mp2
 [vorbis] ogg oga
 [oggflac] ogg oga
 [flac] flac
 [opus] opus ogg oga
 [dsdiff] dff
 [dsf] dsf
 [hybrid_dsd] m4a
 [pcm]

Filters:
 libsamplerate

Tag plugins:
 id3tag

Output plugins:
 null fifo pipe alsa pulse httpd recorder

Encoder plugins:
 null vorbis opus wave flac

Input plugins:
 file alsa curl smbclient nfs

Playlist plugins:
 extm3u m3u pls xspf asx rss flac cue embcue

Protocols:
 file:// alsa:// http:// https:// smb:// nfs://

Other features:
 epoll inotify ipv6 systemd tcp un

Log

That first line shouldn't be there either:

Apr 29 11:12 : exception: Failed to open /media/kids/lost+found: Permission denied
Apr 29 11:17 : exception: Failed to register /media/kids/lost+found: inotify_add_watch
() has failed: Permission denied
[…] # and about 35 more.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants