New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i18n translations #2

Closed
MusikAnimal opened this Issue Feb 9, 2016 · 6 comments

Comments

Projects
None yet
2 participants
@MusikAnimal
Owner

MusikAnimal commented Feb 9, 2016

Date formatting locale is in place, but it'd be nice if we could automatically translate the page. The app could accept a lang=en-US (for instance) to force a particular language, otherwise it will go off of JavaScript's navigator.lang

@MusikAnimal MusikAnimal changed the title from Add i18n to Add i18n translations Feb 13, 2016

@kaldari

This comment has been minimized.

Collaborator

kaldari commented Feb 23, 2016

@kaldari

This comment has been minimized.

Collaborator

kaldari commented Mar 3, 2016

This is pretty much finished in the https://github.com/MusikAnimal/pageviews/tree/php branch. Even the 3rd party components should now use localized messages. The remaining steps are:

  • Add an interface in the Settings dialog to change your language (which should set a cookie).
  • Register pageviews with TranslateWiki so we can start getting translations.
@MusikAnimal

This comment has been minimized.

Owner

MusikAnimal commented Mar 3, 2016

@kaldari 96 files changed at the time of writing! Quite an overhaul, to say the least :)

I think we can move forward with what we have now before adding a language selector.

First however I'd like to try to improve performance (page load, not AJAX). It seems pageviews-test is quite slow compared to pageviews. The overhead of PHP will certainly take a bit of a toll, but I feel like it's going slower than it should be. Hopefully there's some caching mechanism through lighttpd that we could take advantage of. I would expect that if I reload the same page, with the same language cookie, it'd be quick to serve. Any ideas?

@kaldari

This comment has been minimized.

Collaborator

kaldari commented Mar 3, 2016

@MusikAnimal: PHP itself should not make much difference, maybe an extra 100ms. Loading all of Intuition may be what's slowing things down, but it will require some testing to figure out. If there were some way to cache the page, that would certainly help.

@kaldari

This comment has been minimized.

Collaborator

kaldari commented Mar 3, 2016

It looks like loading and initializing Intuition is what is causing the extra slowness. Loading Intuition seems to add about 250-300ms, while initializing Intuition adds another 500ms or so. Add in the PHP overhead and it's almost an extra second.

@kaldari

This comment has been minimized.

Collaborator

kaldari commented Mar 14, 2016

I think this is done now.

@kaldari kaldari closed this Mar 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment