Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazy Initialisation for Mutability Detector #42

Merged
merged 2 commits into from Aug 20, 2013
Merged

Lazy Initialisation for Mutability Detector #42

merged 2 commits into from Aug 20, 2013

Conversation

jufickel
Copy link
Contributor

A new pull request for Lazy Initialisation detection for Mutability Detector.

Juergen Fickel added 2 commits June 11, 2013 16:50
Basic integration of the lazy initialisation functionality.
bf8c14e
Minor changes.
8e2d242 
* Added file header comment to `SetterMethodChecker.java`.
* Extended `SetterMethodCheckerTest.java` by test cases for Lazy
  Initialisation.
* Changed `MutatesAsInternalCaching.java` to be effective immutable
  as using Lazy Initialisation.
@Grundlefleck
Copy link
Contributor

Hi @jufickel

I'm really sorry for the long delay in getting back to you. I haven't forgotten about your contribution!

@jufickel
Copy link
Contributor Author

Nae bother.

Am 16.07.2013 22:31, schrieb Graham Allan:

Hi @jufickel

I'm really sorry for the long delay in getting back to you. I haven't forgotten about your contribution!

Reply to this email directly or view it on GitHub:
#42 (comment)

Grundlefleck added a commit that referenced this pull request Aug 20, 2013
@Grundlefleck
Merge jufickel's pull request #42
93b8d55
@Grundlefleck Grundlefleck merged commit 8e2d242 into MutabilityDetector:master Aug 20, 2013
@Grundlefleck
Copy link
Contributor

Hi Jurgen,

I've manually merged in your changes. Since several of the unit tests were still failing I kept the old 'setter method checker' around while I investigate, as the default.

I really want to take your analysis and push towards a 1.0 release. Does your time schedule permit answering questions, maybe contributing some more?

Many, many thanks!

@Grundlefleck Grundlefleck mentioned this pull request Aug 20, 2013
Closed
@jufickel
Copy link
Contributor Author

Hi Graham,

nice to hear that the changes are merged now. Yes, my time schedule allows answering some questions as well as contributing more. However it might hapen that I am not able to react immediately – unfortunately. I assume that it would be a good idea to have a look at the failing tests at first, wouldn't it?

Kind regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jufickel @Grundlefleck