This repository has been archived by the owner. It is now read-only.

Set tab titles and icons using MvxTabPresentationAttribute #44

Merged
merged 4 commits into from Oct 3, 2016

Conversation

Projects
None yet
2 participants
@nmilcoff
Member

nmilcoff commented Oct 2, 2016

Fixes #43

nmilcoff added some commits Sep 26, 2016

Remove hard-coded tab attributes
- Added Tab attributes as properties inside MvxTabPresentationAttribute
- No longer need to use presentationValues when showing a ViewModel as
a Tab
- Adapted sample
- Fixed some line endings
Merge remote-tracking branch 'MvvmCross/master' into tabs-attributes
- Resolve conflicts (pull Mvx latest version)
- Fix TabsSample Settings.cs class (broken when Settings package got
updated)
@nmilcoff

This comment has been minimized.

Show comment
Hide comment
@nmilcoff

nmilcoff Oct 2, 2016

Member

Fixes #41 to avoid running problems also (closing PR #42)

Member

nmilcoff commented Oct 2, 2016

Fixes #41 to avoid running problems also (closing PR #42)

@martijn00 martijn00 merged commit c677333 into MvvmCross:master Oct 3, 2016

@martijn00

This comment has been minimized.

Show comment
Hide comment
@martijn00

martijn00 Oct 3, 2016

Member

Thanks! Cool change!

Member

martijn00 commented Oct 3, 2016

Thanks! Cool change!

@nmilcoff nmilcoff deleted the DGenix:tabs-attributes branch Nov 24, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.