Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resuming app with tabs as root page causes duplicate page to load as new navigation (MvvmCross 5.4.2 / MvxTabbedPage root) #2373

Closed
mgoodfellow opened this issue Nov 8, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@mgoodfellow
Copy link

commented Nov 8, 2017

Steps to reproduce 馃摐

  1. Latest Xamarin.Forms / MvvmCross 5.4.2

  2. Example Repo here

  3. When the app first runs, a tabbed root page appears with 2 child tabs appears

Expected behavior 馃

If the app is backgrounded, then when it resumes it appears as it did before

Actual behavior 馃悰

When the app resumes, the MainPage is recreated

I've stepped through the code, and when it's recreated _firstTime is false, and so a new page is created, and the tabs added.

However, the old page is still in the stack, so you end up with a back navigation arrow in top-left of toolbar and that takes you back to the old existing MainPage.

I notice that TriggerFirstNavigate from the SplashScreen runs again on resume, and I wonder if it is the responsibility of that to check if the page already exists in the stack? I need to dig further into the MvvmCross code base, but I was hoping the issue might be obvious to you guys!

Thanks!

Configuration 馃敡

Version: 5.4.2

Platform:

  • 馃摫 iOS
  • 馃 Android
  • 馃弫 WPF
  • 馃寧 UWP
  • 馃崕 MacOS
  • 馃摵 tvOS
  • 馃悞 Xamarin.Forms

@martijn00 martijn00 added this to the 5.5.0 milestone Nov 23, 2017

@martijn00

This comment has been minimized.

Copy link
Member

commented Nov 23, 2017

Fixed in 9fbf735

@martijn00 martijn00 closed this Nov 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.