New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comments in MvxLocationWatcher WPF #2911

Closed
Cheesebaron opened this Issue May 28, 2018 · 5 comments

Comments

Projects
None yet
5 participants
@Cheesebaron
Member

Cheesebaron commented May 28, 2018

Steps to reproduce 馃摐

  1. Build sln
  2. Look at output
Platforms\Wpf\MvxWpfLocationWatcher.cs(16,20): warning CS1584: XML comment has syntactically incorrect cref attribute 'http://code.msdn.microsoft.com/windowsdesktop/Windows-7-Geolocation-API-25585fac' [C:\projects\mvvmcross\MvvmCross.Plugins\Location\MvvmCross.Plugin.Location.csproj]
Platforms\Wpf\MvxWpfLocationWatcher.cs(16,74): warning CS1658: Unexpected character '7'. See also error CS1056. [C:\projects\mvvmcross\MvvmCross.Plugins\Location\MvvmCross.Plugin.Location.csproj]
Platforms\Wpf\MvxWpfLocationWatcher.cs(16,92): warning CS1658: Unexpected character '2'. See also error CS1056. [C:\projects\mvvmcross\MvvmCross.Plugins\Location\MvvmCross.Plugin.Location.csproj]
Platforms\Wpf\MvxWpfLocationWatcher.cs(16,93): warning CS1658: Unexpected character '5'. See also error CS1056. [C:\projects\mvvmcross\MvvmCross.Plugins\Location\MvvmCross.Plugin.Location.csproj]
Platforms\Wpf\MvxWpfLocationWatcher.cs(16,94): warning CS1658: Unexpected character '5'. See also error CS1056. [C:\projects\mvvmcross\MvvmCross.Plugins\Location\MvvmCross.Plugin.Location.csproj]
Platforms\Wpf\MvxWpfLocationWatcher.cs(16,95): warning CS1658: Unexpected character '8'. See also error CS1056. [C:\projects\mvvmcross\MvvmCross.Plugins\Location\MvvmCross.Plugin.Location.csproj]
Platforms\Wpf\MvxWpfLocationWatcher.cs(16,96): warning CS1658: Unexpected character '5'. See also error CS1056. [C:\projects\mvvmcross\MvvmCross.Plugins\Location\MvvmCross.Plugin.Location.csproj]
Platforms\Wpf\MvxWpfLocationWatcher.cs(17,24): warning CS1584: XML comment has syntactically incorrect cref attribute 'http://www.techsupportalert.com/content/how-enable-or-disable-location-sensing-windows-7-and-8.htm' [C:\projects\mvvmcross\MvvmCross.Plugins\Location\MvvmCross.Plugin.Location.csproj]
Platforms\Wpf\MvxWpfLocationWatcher.cs(17,111): warning CS1658: Unexpected character '7'. See also error CS1056. [C:\projects\mvvmcross\MvvmCross.Plugins\Location\MvvmCross.Plugin.Location.csproj]
Platforms\Wpf\MvxWpfLocationWatcher.cs(17,117): warning CS1658: Unexpected character '8'. See also error CS1056. [C:\projects\mvvmcross\MvvmCross.Plugins\Location\MvvmCross.Plugin.Location.csproj]

Expected behavior 馃

No false positive warnings with error should appear

Actual behavior 馃悰

Warnings are output with See also error CS1056. Makes it annoying to search for errors in build log

Configuration 馃敡

Version: 6.x

@curtiscali

This comment has been minimized.

curtiscali commented Jul 7, 2018

Is this issue still up for grabs? I'm thinking of trying my hand at it soon.

@nickrandolph

This comment has been minimized.

Contributor

nickrandolph commented Jul 7, 2018

Yes I think if you look at the appveyor build output (or run MSBuild on solution) you will see these warnings

@nickrandolph nickrandolph added the Cleanup label Aug 9, 2018

@niallermoran

This comment has been minimized.

niallermoran commented Aug 22, 2018

Building the solution doesn't seem to cause these warnings for me. I'd like to find an issue to start contributing.

ta

@Cheesebaron

This comment has been minimized.

Member

Cheesebaron commented Aug 22, 2018

@fredeil

This comment has been minimized.

Member

fredeil commented Aug 27, 2018

I'm taking this issue. I will make a PR very soon 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment