Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bindings not attempted in MvxRecycler item template layout when given item in ItemsSource is null #3424

Closed
TSL-DSP opened this issue Jun 6, 2019 · 0 comments

Comments

@TSL-DSP
Copy link

commented Jun 6, 2019

馃悰 Bug Report

I'm binding the ItemsSource of an MvxRecyclerView (using .axml) to a collection of objects in the ViewModel, some of which are null. The issue is that this binding is ignored for Recycler items that are associated with a null ItemsSource element, so the value converter is never called. It is important that this binding is still attempted as the an MvXValueConverter checks to see whether the context passed in is null or not and runs some logic accordingly.

This behaviour doesn't occur in an older app which works without issue using the same design and running MvvmCross 5.7.0.

Expected behavior

Bindings with value converters not ignored within MvxItemTemplate layout when the ItemsSource element is null.

Reproduction steps

Provide MvxRecyclerView with an ItemsSource collection that contains null elements. Set a property binding with a value converter on any view within the MvxItemTemplate layout.

Configuration

Version: 6.3.0

Platform:

  • 馃摫 iOS
  • [鉁擼 馃 Android
  • 馃弫 WPF
  • 馃寧 UWP
  • 馃崕 MacOS
  • 馃摵 tvOS
  • 馃悞 Xamarin.Forms
@TSL-DSP TSL-DSP changed the title Bindings not being called in MvxRecycler item template layout when given item in ItemsSource is null Bindings not attempted in MvxRecycler item template layout when given item in ItemsSource is null Jun 7, 2019
@TSL-DSP TSL-DSP closed this Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can鈥檛 perform that action at this time.