Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Touch should support RequestRemoveBackStep #80

Closed
slodge opened this Issue · 5 comments

2 participants

Stuart Lodge Jason Steele
Stuart Lodge
Owner

See - http://stackoverflow.com/questions/13934748/remove-viewcontroller-from-stack-using-mono-touch-and-slodge-mvvmcross

This should at least be routed through to the Presenter.

Sadly it proved a bit awkward to implement this at a generic level for iOS - so currently that method is:

    public bool RequestRemoveBackStep()
    {
#warning What to do with ios back stack?
        // not supported on iOS really
        return false;
    }

from https://github.com/slodge/MvvmCross/blob/vnext/Cirrious/Cirrious.MvvmCross.Touch/Views/MvxTouchViewDispatcher.cs

Stuart Lodge
Owner

I started to look at this.... but actually I think the bug is in the design.

I suspect we need to instead let a view model remove itself from the back stack - so we somehow need an API like RequestRemove(IMvxViewModel toRemove) - and we need this across all platforms.... need to think about it....

Stuart Lodge
Owner

I have at least routed the current message through to the presenter now

Stuart Lodge
Owner

Should we just remove this function from the interface now? It's not really available 'free' on all platforms...

Jason Steele

Hi Stuart, I agree with your statement "I suspect we need to instead let a view model remove itself from the back stack" and RequestRemoveBackStep should be dropped.

Stuart Lodge
Owner

v3 removes this from every single platform.

Apps need this will need to work out the pattern to use.

Love the new style - much cleaner :)

Stuart Lodge slodge closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.