Fix nuspec derpage #1726
Merged
Fix nuspec derpage #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijn00
approved these changes
Apr 25, 2017
kjeremy
reviewed
Apr 25, 2017
|
|
||
| <!-- dotnet --> | ||
| <file src="..\bin\Release\Mvx\Portable\MvvmCross.Core.*" target="lib\dotnet" /> | ||
|
|
||
| <!-- console --> | ||
| <file src="..\bin\Release\Mvx\Console\MvvmCross.Console.*" target="lib\net45" /> |
There was a problem hiding this comment.
Just as a note: this looks weird to me.
There was a problem hiding this comment.
Why? Core is already included in the core project which is a dependency.
There was a problem hiding this comment.
Sorry that comment applied to the inclusion of Console.*. I just didn't expect it.
kjeremy
approved these changes
Apr 25, 2017
|
Don't merge this yet. I see an issue. pdb.srcsrv are not added to nuget packages either. Need to fix that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #1725 there were some issues with our nuspecs. Some of it probably my fault 😄
This should fix this 🎉