Removing AfterBuild CustomCommands #180

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@mShady
mShady commented Mar 1, 2013

Removed the parts below (twice) as they break the build on Xamarin Studio (and removing them doesn't break the build on VS)
Also, as far as I understand, a non-Windows OS won't have that conflict and won't need using this assembly in the first place.

<CustomCommands Condition="'$(OS)' != 'Windows_NT'">
  <CustomCommands>
    <Command type="AfterBuild" command="mv System.Net.Droid.dll System.Net.dll" workingdir="${TargetDir}" />
  </CustomCommands>
</CustomCommands>
@mShady mShady Removing AfterBuild CustomCommands
Removed the parts below (twice) as they break the build on Xamarin Studio (and removing them doesn't break the build on VS)
Also, supposedly, a non-Windows OS would be using mono anyway and won't need using this assembly in the first place.
<CustomCommands Condition="'$(OS)' != 'Windows_NT'">
  <CustomCommands>
    <Command type="AfterBuild" command="mv System.Net.Droid.dll System.Net.dll" workingdir="${TargetDir}" />
  </CustomCommands>
</CustomCommands>
ee3b3db
@slodge
Contributor
slodge commented Mar 2, 2013

Thanks mShady :)

Hoping to get on to this this weekend for some serious testing - will merge and test this change when I do.

The new tools are breaking all sorts of things - and when proper PCL support arrives there will be more breaks - just taking it one step at a time :)

Thanks

Stuart

@mShady
mShady commented Mar 2, 2013

Great, let me know if I could be of any help. I'd really love to.

Just as a side note, I also checked the System.Windows.Droid project. It doesn't have a similar command. So, I think, both should have it either added or removed.

@slodge
Contributor
slodge commented Mar 2, 2013

Cross referencing to the reason this was introduced.

#60

and

http://stackoverflow.com/questions/12433701/building-a-system-net-surrogate-dll-under-monotouch-avoiding-a-friend-access

While the new Xam tools may change this problem, I still have users and customers using VSMonoTouch - they;re still thinking about the $600 price rise...

@slodge
Contributor
slodge commented Apr 12, 2013

Still tracking this - hoping to talk to some experts at Evolve next week... need to know if they are going to ship these assemblies or not.

@slodge
Contributor
slodge commented May 17, 2013

These are still open... but any day now Xamarin PCL support may arrive... still tracking

@slodge
Contributor
slodge commented Jul 23, 2013

Still tracking the Xamarin PCL support... hope to be able to close this soon....

@mShady
mShady commented Dec 2, 2013

Any updates?

@slodge
Contributor
slodge commented Dec 6, 2013

Yes - we've moved the work on the "official PCL support" over to the new v3.1 fork. Because Xam are now shipping forwarding assemblies, none of these projects should be needed any more... so I can finally close this pull request.

Thanks again for your time on this - very glad we will finally have "official" PCL support :)

@slodge slodge closed this Dec 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment