The AppBarLayout should be direct child of the CoordinatedLayout
#2012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijn00
suggested changes
Jul 4, 2017
| @@ -85,15 +85,17 @@ protected IMvxImageHelper<Bitmap> ImageHelper | |||
| } | |||
| } | |||
|
|
|||
| public MvxImageView(Context context, IAttributeSet attrs, int defStyleAttr, int defStyleRes) | |||
| public MvxImageView(Context context, IAttributeSet attrs, int defStyleAttr, int defStyleRes) | |||
There was a problem hiding this comment.
This looks like it is not rebased on develop?
There was a problem hiding this comment.
nope correct I accidentally merged and squashed
There was a problem hiding this comment.
Want me to correct it?
Fix `MissingMethodException` when using `MvxImageView` on everything before Android API 21 Fix spacing issue
mvanbeusekom
force-pushed
the
feature/fix_androidsupport_toolbar_layout
branch
from
5e06f50
to
6b78847
Compare
martijn00
approved these changes
Jul 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Bug fix
Currently in the AndroidSupport test project there are some fragments where the
AppBarLayoutcontrol is not a direct child of theCoordinatedLayoutcontrol.🆕 What is the new behavior (if this is a feature change)?
The
AppBarLayoutcontrol is now a direct child of theCoordinatedLayoutcontrol💥 Does this PR introduce a breaking change?
No
🐛 Recommendations for testing
Run the AndroidSupport test project
📝 Links to relevant issues/docs
Link to Google documentation:
🤔 Checklist before submitting