Add some missing binding extension properties #2313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd love to see a UnitTest testing the Markup Extension. @jonathanpeppers has some mocks for Forms here that could be used for setting up the tests: https://github.com/jonathanpeppers/Xamarin.Forms.Mocks |
Cheesebaron
previously requested changes
Oct 30, 2017
|
|
||
| public object ProvideValue(IServiceProvider serviceProvider) | ||
| { | ||
| IProvideValueTarget target = serviceProvider.GetService(typeof(IProvideValueTarget)) as IProvideValueTarget; |
There was a problem hiding this comment.
This looks strange to me. You are requesting a IProvideValueTarget then casting it to IProvideValueTarget right after. Could probably be done a lot cleaner.
Cheesebaron
reviewed
Oct 30, 2017
| } | ||
| else | ||
| { | ||
| Mvx.Trace(MvxTraceLevel.Diagnostic, "Cannot only use MvxBind on a bindable property"); |
Cheesebaron
reviewed
Oct 30, 2017
| } | ||
| else | ||
| { | ||
| Mvx.Trace(MvxTraceLevel.Diagnostic, "Cannot only use MvxBind on a bindable property"); | ||
| Mvx.Trace(MvxTraceLevel.Diagnostic, "Cannot only use MvxLang on a bindable property"); |
martijn00
force-pushed
the
forms-bindings
branch
from
b9b9c0d
to
a13b230
Compare
martijn00
force-pushed
the
forms-bindings
branch
from
aa1ad80
to
d8dd04c
Compare
nmilcoff
approved these changes
Oct 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Bug fixes
🆕 What is the new behavior (if this is a feature change)?
💥 Does this PR introduce a breaking change?
🐛 Recommendations for testing
📝 Links to relevant issues/docs
Some fixes for #2299
🤔 Checklist before submitting