Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parameter overview #2377

Merged
merged 7 commits into from Nov 11, 2017

Conversation

Projects
None yet
3 participants
@mvanbeusekom
Copy link
Member

commented Nov 10, 2017

What kind of change does this PR introduce? (Bug fix, feature, docs update...)

docs update

⤵️ What is the current behavior?

Parameters for the different attributes are listed as bullet point and missing type information. This makes it a bit hard to read.

🆕 What is the new behavior (if this is a feature change)?

Parameters are listed in a table overview improving the readability (also includes type information).

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

N/A

📝 Links to relevant issues/docs

N/A

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • Relevant documentation was updated (docs style guide)
  • Nuspec files were updated (when applicable)
  • Rebased onto current develop

mvanbeusekom added some commits Nov 10, 2017

@nmilcoff
Copy link
Member

left a comment

I guess we need to update all presenter docs :)

@mvanbeusekom

This comment has been minimized.

Copy link
Member Author

commented Nov 10, 2017

Yes Martijn also mentioned it and I agree. I will update them after dinner 😉

mvanbeusekom added some commits Nov 10, 2017

@mvanbeusekom mvanbeusekom dismissed stale reviews from nmilcoff and martijn00 via 5e277ed Nov 10, 2017

mvanbeusekom added some commits Nov 10, 2017

@mvanbeusekom

This comment has been minimized.

Copy link
Member Author

commented Nov 10, 2017

Updated parameter list for the other presenters.

@nmilcoff
Copy link
Member

left a comment

Awesome!

@martijn00 martijn00 changed the base branch from develop to master Nov 11, 2017

@martijn00 martijn00 changed the base branch from master to develop Nov 11, 2017

@martijn00 martijn00 added this to the 5.5.0 milestone Nov 11, 2017

@martijn00 martijn00 merged commit 8a96105 into MvvmCross:develop Nov 11, 2017

3 checks passed

CodeFactor No issues found.
Details
WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.