Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separation of concerns for Playground sample v2 #2381

Merged
merged 4 commits into from Nov 13, 2017

Conversation

Projects
None yet
2 participants
@nickrandolph
Copy link
Contributor

commented Nov 13, 2017

What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Update Samples

⤵️ What is the current behavior?

Both view and view models are included in the same project (Playground.Core) which means that all head projects need to reference Xamarin Forms.

🆕 What is the new behavior (if this is a feature change)?

Views have been moved into their own project (Playground.UI).
This demonstrates good separation of concerns for the Playground sample

💥 Does this PR introduce a breaking change?

No, as it does change any behaviour of the libraries themselves

🐛 Recommendations for testing

Make sure Playground sample runs on all target platforms

📝 Links to relevant issues/docs

N/A

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • Relevant documentation was updated (docs style guide)
  • Nuspec files were updated (when applicable)
  • Rebased onto current develop

nickrandolph added some commits Nov 12, 2017

Fixing reflection - null reference exception
Refactor of playground sample to separate views and viewmodels

@martijn00 martijn00 added this to the 5.5.0 milestone Nov 13, 2017

@martijn00 martijn00 merged commit d285e85 into MvvmCross:develop Nov 13, 2017

2 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
CodeFactor 1 issue fixed.
Details
WIP ready for review
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.