Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update caching PagerAdapter to AndroidX implementation #3120

Merged
merged 1 commit into from Sep 25, 2018

Conversation

Cheesebaron
Copy link
Member

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

bugfix

Fixes issues saving state when fragment was never added.

Fixes transaction issues on FinishUpdate.

💥 Does this PR introduce a breaking change?

Nope

🐛 Recommendations for testing

📝 Links to relevant issues/docs

🤔 Checklist before submitting

@Cheesebaron Cheesebaron requested a review from a team September 25, 2018 09:55
@Cheesebaron Cheesebaron added t/bug Bug type p/android-support Android Support Packages platform labels Sep 25, 2018
martijn00
martijn00 previously approved these changes Sep 25, 2018
@martijn00 martijn00 added this to the 6.2.1 milestone Sep 25, 2018
@Cheesebaron
Copy link
Member Author

Will resolve the conflicts in a moment and revert the AndroidFragment thing, since it should be solved in a different way.

@Cheesebaron Cheesebaron changed the title Update caching PagerAdapter to AndroidX implementation [WIP] Update caching PagerAdapter to AndroidX implementation Sep 25, 2018
@Cheesebaron Cheesebaron changed the title [WIP] Update caching PagerAdapter to AndroidX implementation Update caching PagerAdapter to AndroidX implementation Sep 25, 2018
@martijn00 martijn00 merged commit 198002f into develop Sep 25, 2018
@Cheesebaron Cheesebaron deleted the bugfix/pageradapters branch September 26, 2018 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p/android-support Android Support Packages platform t/bug Bug type
Development

Successfully merging this pull request may close these issues.

None yet

2 participants