Facade MvxViewModelInstanceRequest instance overwritten #3405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce of a ViewModel, use that instance rather than load a new one for NavigationRouteRequest
|
|
martijn00
approved these changes
May 17, 2019
…to an expected race condition not because of a behavior or logic change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If facade request returns a MvxViewModelInstanceRequest with an instance of a ViewModel, use that instance rather than load a new one for NavigationRouteRequest
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Returning a MvxViewModelInstanceRequest (with a VM instance) in an IMvxNavigationFacade results in that instance not being used for the resulting navigation. This change checks for an existing instance in the request and uses that instance instead of loading a new one.
🆕 What is the new behavior (if this is a feature change)?
💥 Does this PR introduce a breaking change?
no
🐛 Recommendations for testing
📝 Links to relevant issues/docs
🤔 Checklist before submitting