Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal Popover Presentation Crash #3516

Merged

Conversation

@Prin53
Copy link
Member

commented Aug 27, 2019

What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Set view controller preferred content size before wrapping in navigation controller.

⤵️ What is the current behavior?

Content size set after the wrapping in navigation controller and leads to crash.

🆕 What is the new behavior (if this is a feature change)?

None

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

None

📝 Links to relevant issues/docs

#3515.

🤔 Checklist before submitting

@Prin53 Prin53 requested a review from MvvmCross/core as a code owner Aug 27, 2019
@martijn00 martijn00 added this to the 6.4.0 milestone Aug 27, 2019
@martijn00

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

Thanks! These PR's are really helpful!

@martijn00 martijn00 merged commit b513ccb into MvvmCross:develop Aug 27, 2019
3 checks passed
3 checks passed
CodeFactor No issues found.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.