New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Email.Touch plugin bug for CC emails #731

Merged
merged 2 commits into from Jul 10, 2014

Conversation

Projects
None yet
3 participants
@Laumania
Contributor

Laumania commented Jun 30, 2014

Fixed bug in Email.Touch, where the EmailCompose dialog wasn't shown due to an " is not an valid email" error in the debug window.
It seems (iOS7 at least, haven't had a chance to test this on iOS 6.0) doesn't allow an array with an empty string in it as params to the SetCcRecipients, as it then tries to valid the empty string as an email.

Laumania added some commits Jun 30, 2014

* Fixed bug in Email.Touch, where the EmailCompose dialog wasn't show…
…n due to an " is not an valid email" error in the debug window. It seems (iOS7 at least?) doesn't allow an array with an empty string in it as params to the SetCcRecipients, as it then tries to valid the empty string as an email.
* Changed indentation from tabs to spaces (did it manually, as I coul…
…dn't figure a way to make Xamarin Studio on OSX do it automatically?)

slodge added a commit that referenced this pull request Jul 10, 2014

Merge pull request #731 from Laumania/v3.1
Fixed Email.Touch plugin bug for CC emails

@slodge slodge merged commit 27a4a78 into MvvmCross:v3.1 Jul 10, 2014

@slodge

This comment has been minimized.

Show comment
Hide comment
@slodge

slodge Jul 10, 2014

Contributor

Thanks

Contributor

slodge commented Jul 10, 2014

Thanks

@Laumania

This comment has been minimized.

Show comment
Hide comment
@Laumania

Laumania Jul 10, 2014

Contributor

No problem :)

Contributor

Laumania commented Jul 10, 2014

No problem :)

@martijn00 martijn00 added this to the 3.1.x milestone Jan 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment