New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the like button in tapatalk #34

Closed
andrewjs18 opened this Issue Aug 8, 2018 · 11 comments

Comments

Projects
None yet
4 participants
@andrewjs18

andrewjs18 commented Aug 8, 2018

this is an enhancement that the thank you/like plugin had. since a lot of people like tapatalk, they like this feature.

@euantorano

This comment has been minimized.

Contributor

euantorano commented Aug 8, 2018

@andrewjs18

This comment has been minimized.

andrewjs18 commented Aug 8, 2018

perhaps we can ask Eldenroot as he has it integrated in his plugin.

@Eldenroot

This comment has been minimized.

Eldenroot commented Aug 8, 2018

Hi guys. Tapatalk support was added by an original plugin author G33K. I just overtook abandoned plugin and maintain it. So I am not sure how to add it.

However I dont recommend to add it, it is quite buggy and Tapatalk is getting less popular. Also there is no detailed documentation. Anyway it is up to you, try to check the code used in Thank you/like plugin, maybe it could help.

@euantorano

This comment has been minimized.

Contributor

euantorano commented Aug 8, 2018

I'll have a look, thanks @Eldenroot!

@andrewjs18

This comment has been minimized.

andrewjs18 commented Aug 9, 2018

thanks for the feedback, @Eldenroot

@chack1172

This comment has been minimized.

Contributor

chack1172 commented Aug 9, 2018

So, after some search I found out that the tapatalk integration is not done in the thank you/like plugin system. The tapatalk mybb plugin has been developed integrating that plugin so the only way to make this plugin work in tapatalk is to edit tapatalk plugin.

@andrewjs18

This comment has been minimized.

andrewjs18 commented Aug 9, 2018

interesting. but how does it reapply those edits when tapatalk is updated?

@andrewjs18

This comment has been minimized.

andrewjs18 commented Aug 9, 2018

@euantorano @chack1172, if I reach out to tapatalk about adding support for this plugin, what's the best way we can integrate the 2?

@chack1172

This comment has been minimized.

Contributor

chack1172 commented Aug 9, 2018

I don't know at the moment. I'm checking tapatalk files to understand how they do it with thank you/like plugin.

@andrewjs18

This comment has been minimized.

andrewjs18 commented Aug 9, 2018

perhaps something can be implemented like the google seo plugin uses where after a forum update is performed, you have the ability to reapply the core edits via a button on the plugins page. of course rather than a core forum update, it'd apply to tapatalk updates..

@andrewjs18

This comment has been minimized.

andrewjs18 commented Aug 10, 2018

perfect. nice work with the PR, @chack1172.

@andrewjs18 andrewjs18 closed this Aug 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment