Create script to update tokens list from ethereum-lists/tokens #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbobeirne
added
status: ready for review
|
Looks like CI is failing with the new tokens, which probably means we'll need to clean up |
|
I fixed the incorrect decimals issue, the json from IPFS had decimals as strings, not ints. Fixed that up during import:
|
This was referenced Mar 8, 2018
Merged
* Update scripts to handle collisions, and use typescript * Add comment on duplicateAddress validator * Lock dep on ts-node * Fix tsc errors
dternyak
approved these changes
Apr 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triage temporary solution for #969.
Description
Right now we've just been keeping up to date with MyCryptoHQ/mycrypto.com for token lists changes, but the future plan is to use ethereum-lists/tokens as our source of tokens. The problem is its format is kind of spread out and not easy to import directly to our repo. This PR adds a script that fetches its output from IPFS, imports and formats the tokens to match our format, and stages the tokens for commit. This won't stop us from manually updating, but should make the process much easier.
One concern of this change is that our token list has ballooned from ~90 to 513 with this. This'll be a much larger load on our node, and probably includes a lot of junk tokens. Not to mention, some of them don't use proper symbol acronyms, and instead have rather long names. We may want to either audit
ethereum-lists/tokensand clean out any useless ones, or implement a blacklist of tokens to exclude.Also of note, I'm not sure decimals or amounts are being handled properly right now with tokens. See screenshot below.Fixed, see comment below.Changes
scripts/folder that fetches tokens.Steps to Test
eth-lists-scriptnpm run update:tokensScreenshots
^ Are these amounts correct? Is something wrong with decimals?