Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Ledger and remove hack #3879

Merged
merged 1 commit into from Mar 4, 2021
Merged

Bump Ledger and remove hack #3879

merged 1 commit into from Mar 4, 2021

Conversation

FrederikBolding
Copy link
Collaborator

@FrederikBolding FrederikBolding commented Mar 4, 2021

Following LedgerHQ/ledgerjs@a1f21d2 this release of Ledger libs should work with EWC without the hack.

@FrederikBolding FrederikBolding temporarily deployed to STAGING March 4, 2021 10:47 Inactive
@mycrypto-bot
Copy link
Collaborator

Staging build: MyCryptoBuilds

@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #3879 (53d34d5) into master (1d0f824) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3879      +/-   ##
==========================================
- Coverage   63.71%   63.68%   -0.04%     
==========================================
  Files         591      591              
  Lines       12427    12415      -12     
  Branches     3120     3118       -2     
==========================================
- Hits         7918     7906      -12     
  Misses       4482     4482              
  Partials       27       27              
Impacted Files Coverage Δ
src/services/WalletService/deterministic/ledger.ts 39.18% <ø> (-8.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d0f824...53d34d5. Read the comment docs.

@FrederikBolding
Copy link
Collaborator Author

FrederikBolding commented Mar 4, 2021

@vilsbole vilsbole merged commit 2f6e33a into master Mar 4, 2021
@vilsbole vilsbole deleted the fb/bump-ledger branch March 4, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants