Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/mew decision tree new #1442

Merged
merged 50 commits into from Oct 10, 2019
Merged

Dev/mew decision tree new #1442

merged 50 commits into from Oct 10, 2019

Conversation

hsurf22
Copy link
Contributor

@hsurf22 hsurf22 commented Sep 19, 2019

Feature

  • Updated CHANGELOG.md
  • Add PR label
    • Add decision tree

https://www.youtube.com/watch?v=U4tEnBwLbc0&feature=youtu.be

Screenshot from 2019-09-18 21-26-52

@codecov
Copy link

codecov bot commented Sep 19, 2019

Codecov Report

Merging #1442 into develop will increase coverage by 0.39%.
The diff coverage is 18.75%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1442      +/-   ##
===========================================
+ Coverage    20.02%   20.41%   +0.39%     
===========================================
  Files          332      328       -4     
  Lines         8985     8842     -143     
  Branches      1644     1619      -25     
===========================================
+ Hits          1799     1805       +6     
+ Misses        6682     6533     -149     
  Partials       504      504
Impacted Files Coverage Δ
src/components/CustomerSupport/CustomerSupport.vue 90% <0%> (-10%) ⬇️
...ecisionTree/components/MdContainer/MdContainer.vue 0% <0%> (ø)
...ree/components/SearchContainer/SearchContainer.vue 0% <0%> (ø)
src/containers/HeaderContainer/HeaderContainer.vue 51.89% <100%> (+0.61%) ⬆️
src/components/DecisionTree/DecisionTree.vue 17.85% <17.85%> (ø)
src/builds/configs/base-routes.js 0% <0%> (ø) ⬆️
src/layouts/GettingStarted/GettingStarted.vue 85% <0%> (ø) ⬆️
src/translations/en_US.js 100% <0%> (ø) ⬆️
src/builds/web/app.vue 0% <0%> (ø) ⬆️
src/containers/FooterContainer/FooterContainer.vue 28.57% <0%> (ø) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2e1453...32d6e12. Read the comment docs.

@SteveMieskoski
Copy link
Contributor

Also, noticed the 'house' home icon on the bottom has hover effects, but doesn't have a click event. (does not do anything when clicked)

@hsurf22 hsurf22 removed the Ready Tag for when a PR is ready to merge label Sep 20, 2019
@hsurf22 hsurf22 added the Ready Tag for when a PR is ready to merge label Sep 20, 2019
@hsurf22
Copy link
Contributor Author

hsurf22 commented Sep 20, 2019

This should probably show in all pages, not just the home page.

Yes. I think this is showing on all other pages.
I just tested it and works on all pages.

@hsurf22
Copy link
Contributor Author

hsurf22 commented Sep 20, 2019

Also, noticed the 'house' home icon on the bottom has hover effects, but doesn't have a click event. (does not do anything when clicked)

This button brings user to the very top of the decision tree category.
Now home button is hidden when user is on top category, so users can't see the button.

@hsurf22
Copy link
Contributor Author

hsurf22 commented Sep 23, 2019

Markup data has been updated
and some design changes have been made.

@gamalielhere gamalielhere dismissed their stale review October 9, 2019 21:41

being resolved

@gamalielhere gamalielhere merged commit 6fbc526 into develop Oct 10, 2019
@gamalielhere gamalielhere deleted the dev/mew-decision-tree-new branch October 10, 2019 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature tasks Ready Tag for when a PR is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants