diff --git a/CHANGELOG.md b/CHANGELOG.md index a59289567b..ef8c1d9b8c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,7 @@ ### Bug * fix show private key in paper wallet for non pubKeyOnly wallets \[#3239]https://github.com/MyEtherWallet/MyEtherWallet/pull/3239) +* Format 24 hour change percentage on module balance [#3248](https://github.com/MyEtherWallet/MyEtherWallet/pull/3248) ### Feature diff --git a/package-lock.json b/package-lock.json index b46e0f72fe..205bd679f2 100644 --- a/package-lock.json +++ b/package-lock.json @@ -8387,9 +8387,9 @@ } }, "@myetherwallet/mew-components": { - "version": "0.5.89-beta", - "resolved": "https://registry.npmjs.org/@myetherwallet/mew-components/-/mew-components-0.5.89-beta.tgz", - "integrity": "sha512-tYHp6kxhcC0yp6oC5YGYlPC2YUiwZAMkHdwZAQp6/PnyYI9K3Hsn8i4F4XIjfMZQbgqIRaA9ssuFrGD9q9/mwA==", + "version": "0.5.90-beta", + "resolved": "https://registry.npmjs.org/@myetherwallet/mew-components/-/mew-components-0.5.90-beta.tgz", + "integrity": "sha512-v3XYX9OA29mIZANeKAAKF2D66zX9xL3G6c15SHwCZys7I30rBXdkc7q/FY1d26QbMANrdYKWjMgYQCalDus4TQ==", "requires": { "@rollup/plugin-replace": "^2.3.4", "@vue/babel-preset-app": "^4.4.6", @@ -16629,6 +16629,11 @@ "eslint-visitor-keys": "^1.1.0" } }, + "follow-redirects": { + "version": "1.14.1", + "resolved": "https://registry.npmjs.org/follow-redirects/-/follow-redirects-1.14.1.tgz", + "integrity": "sha512-HWqDgT7ZEkqRzBvc2s64vSZ/hfOceEol3ac/7tKwzuvEyWx3/4UegXh5oBOIotkGsObyk3xznnSRVADBgWSQVg==" + }, "lodash": { "version": "4.17.21", "resolved": "https://registry.npmjs.org/lodash/-/lodash-4.17.21.tgz", @@ -29794,6 +29799,24 @@ "integrity": "sha1-rT/0yG7C0CkyL1oCw6mmBslbP1k=", "optional": true }, + "encoding": { + "version": "0.1.13", + "resolved": "https://registry.npmjs.org/encoding/-/encoding-0.1.13.tgz", + "integrity": "sha512-ETBauow1T35Y/WZMkio9jiM0Z5xjHHmJ4XmjZOq1l/dXz3lr2sRn87nJy20RupqSh1F2m3HHPSp8ShIPQJrJ3A==", + "requires": { + "iconv-lite": "^0.6.2" + }, + "dependencies": { + "iconv-lite": { + "version": "0.6.2", + "resolved": "https://registry.npmjs.org/iconv-lite/-/iconv-lite-0.6.2.tgz", + "integrity": "sha512-2y91h5OpQlolefMPmUlivelittSWy0rP+oYVpn6A7GwVHNE8AWzoYOBNmlwks3LobaJxgHCYZAnyNo2GgpNRNQ==", + "requires": { + "safer-buffer": ">= 2.1.2 < 3.0.0" + } + } + } + }, "encoding-down": { "version": "5.0.4", "resolved": "https://registry.npmjs.org/encoding-down/-/encoding-down-5.0.4.tgz", @@ -31575,13 +31598,10 @@ "node-fetch": "~1.7.1" }, "dependencies": { - "iconv-lite": { - "version": "0.6.3", - "resolved": "https://registry.npmjs.org/iconv-lite/-/iconv-lite-0.6.3.tgz", - "integrity": "sha512-4fCk79wshMdzMp2rH06qWrJE4iolqLhCUH+OiuIgU++RB0+94NlDL81atO7GX55uUKueo0txHNtvEyI6D7WdMw==", - "requires": { - "safer-buffer": ">= 2.1.2 < 3.0.0" - } + "is-stream": { + "version": "1.1.0", + "resolved": "https://registry.npmjs.org/is-stream/-/is-stream-1.1.0.tgz", + "integrity": "sha1-EtSj3U5o4Lec6428hBc66A2RykQ=" }, "node-fetch": { "version": "1.7.3", @@ -31590,16 +31610,6 @@ "requires": { "encoding": "^0.1.11", "is-stream": "^1.0.1" - }, - "dependencies": { - "encoding": { - "version": "0.1.13", - "resolved": "https://registry.npmjs.org/encoding/-/encoding-0.1.13.tgz", - "integrity": "sha512-ETBauow1T35Y/WZMkio9jiM0Z5xjHHmJ4XmjZOq1l/dXz3lr2sRn87nJy20RupqSh1F2m3HHPSp8ShIPQJrJ3A==", - "requires": { - "iconv-lite": "^0.6.2" - } - } } } } @@ -48778,6 +48788,11 @@ "to-array": "0.1.4" }, "dependencies": { + "ms": { + "version": "2.1.3", + "resolved": "https://registry.npmjs.org/ms/-/ms-2.1.3.tgz", + "integrity": "sha512-6FlzubTLZG3J2a/NVCAleEhjzq5oxgHyaCU9yYXvcLsvoVaHJq/s5xXI6/XXP6tz7R9xAOtHnSO/tXtF3WRTlA==" + }, "socket.io-parser": { "version": "3.4.1", "resolved": "https://registry.npmjs.org/socket.io-parser/-/socket.io-parser-3.4.1.tgz", @@ -48788,6 +48803,14 @@ "isarray": "2.0.1" }, "dependencies": { + "debug": { + "version": "4.1.1", + "resolved": "https://registry.npmjs.org/debug/-/debug-4.1.1.tgz", + "integrity": "sha512-pYAIzeRo8J6KPEaJ0VWOh5Pzkbw/RetuzehGM7QRRX5he4fPHx2rdKMB256ehJCkX+XRQm16eZLqLNS8RSZXZw==", + "requires": { + "ms": "^2.1.1" + } + }, "isarray": { "version": "2.0.1", "resolved": "https://registry.npmjs.org/isarray/-/isarray-2.0.1.tgz", @@ -48868,6 +48891,26 @@ "component-emitter": "1.2.1", "debug": "~4.1.0", "isarray": "2.0.1" + }, + "dependencies": { + "component-emitter": { + "version": "1.2.1", + "resolved": "https://registry.npmjs.org/component-emitter/-/component-emitter-1.2.1.tgz", + "integrity": "sha1-E3kY1teCg/ffemt8WmPhQOaUJeY=" + }, + "debug": { + "version": "4.1.1", + "resolved": "https://registry.npmjs.org/debug/-/debug-4.1.1.tgz", + "integrity": "sha512-pYAIzeRo8J6KPEaJ0VWOh5Pzkbw/RetuzehGM7QRRX5he4fPHx2rdKMB256ehJCkX+XRQm16eZLqLNS8RSZXZw==", + "requires": { + "ms": "^2.1.1" + } + }, + "ms": { + "version": "2.1.3", + "resolved": "https://registry.npmjs.org/ms/-/ms-2.1.3.tgz", + "integrity": "sha512-6FlzubTLZG3J2a/NVCAleEhjzq5oxgHyaCU9yYXvcLsvoVaHJq/s5xXI6/XXP6tz7R9xAOtHnSO/tXtF3WRTlA==" + } } } } diff --git a/package.json b/package.json index 2faee26f19..c74c107ce7 100644 --- a/package.json +++ b/package.json @@ -39,7 +39,7 @@ "@ensdomains/address-encoder": "0.2.6", "@ensdomains/ens-contracts": "0.0.5", "@myetherwallet/eth2-keystore": "0.2.3", - "@myetherwallet/mew-components": "0.5.89-beta", + "@myetherwallet/mew-components": "0.5.90-beta", "@myetherwallet/mewconnect-web-client": "2.1.23-beta.9", "@sentry/browser": "6.8.0", "@sentry/tracing": "6.8.0", diff --git a/src/modules/balance/ModuleBalance.vue b/src/modules/balance/ModuleBalance.vue index 472b3737c6..e8a410bb31 100644 --- a/src/modules/balance/ModuleBalance.vue +++ b/src/modules/balance/ModuleBalance.vue @@ -110,6 +110,7 @@ import BalanceEmptyBlock from './components/BalanceEmptyBlock'; import handlerBalanceHistory from './handlers/handlerBalanceHistory.mixin'; import { mapGetters, mapState } from 'vuex'; import { + formatPercentageValue, formatFiatValue, formatBalanceEthValue } from '@/core/helpers/numberFormatHelper'; @@ -176,7 +177,9 @@ export default { */ formatChange() { if (this.fiatLoaded) { - return this.networkTokenUSDMarket.price_change_percentage_24h; + return formatPercentageValue( + this.networkTokenUSDMarket.price_change_percentage_24h + ).value; } return ''; },