Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: json-file per token #347

Closed
ligi opened this issue Jan 10, 2018 · 9 comments
Closed

Discussion: json-file per token #347

ligi opened this issue Jan 10, 2018 · 9 comments
Labels

Comments

@ligi
Copy link
Contributor

@ligi ligi commented Jan 10, 2018

Was just preparing the PR for WETH (#346) and had the following thought:

I would suggest moving from the fat json to multiple smaller ones and assemble them just for usage to one file. I see the following advantages:

  • easy to add a new one - just copy an old one or a template and edit it - instead of editing in this huge json which we now have
  • easier reviewing - better visibility of changes
  • we can get sorting for free
  • we get deduplication of symbols for free

what do you think @tayvano @409H ?
I would write the splitter/joiner and make the PR - but we should make a consolidated effort to try to close all PRs before and merge things timely to not break PRs and invalidate done work in the transition period this way.

@ligi ligi added the discussion label Jan 10, 2018
@409H
Copy link
Contributor

@409H 409H commented Jan 10, 2018

Essentially, are you proposing we have 1 .json file per token?

@ligi
Copy link
Contributor Author

@ligi ligi commented Jan 10, 2018

yes - in the repo - for consumption in apps like MEW or WALLETH they would be combined to one large json containing the array as currently

@409H
Copy link
Contributor

@409H 409H commented Jan 10, 2018

Gotcha. Would they be combined into one large json with something like a CI or is that down the consumers side?

@ligi
Copy link
Contributor Author

@ligi ligi commented Jan 10, 2018

Could be done with a CI - would add this to the scripts and kontinuum could build them like it is building the current minified jsons:

https://gateway.ipfs.io/ipfs/QmeUvS1KxRobZD5fjPeAL6jKLuyB7xve1LZ4G5zAmz2eqm

@409H
Copy link
Contributor

@409H 409H commented Jan 10, 2018

Great - then I see no issue in doing it as you propose 👍

@tayvano
Copy link
Contributor

@tayvano tayvano commented Jan 22, 2018

I agree. We discussed this as well. We will likely include token symbol, name, decimals, address in one API endpoint (and with build of MEW) and API endpoints for each individual token with the additional data.

@ligi
Copy link
Contributor Author

@ligi ligi commented Feb 15, 2018

now implemented in the ethereum-lists organisation: http://walleth.org/2018/02/15/ethereum-lists

@stale
Copy link

@stale stale bot commented Aug 22, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed within 10 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 22, 2020
@stale
Copy link

@stale stale bot commented Sep 2, 2020

Closing because of inactivity

@stale stale bot closed this Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants