Skip to content
This repository has been archived by the owner on Jun 1, 2024. It is now read-only.

Show pump operation time in graph summary #21

Merged
merged 3 commits into from
Nov 13, 2022

Conversation

MyForest
Copy link
Owner

@MyForest MyForest commented Nov 13, 2022

Shows operation proportion below heading "Pumps":

image

I did this outside the chart because I wanted the chart legend to stay focused on showing the value from the the chart line.

@MyForest MyForest merged commit ba2ccb0 into master Nov 13, 2022
@MrTimbones
Copy link
Contributor

MrTimbones commented Nov 14, 2022

mmspheatpump.php is missing a <script> tag to load active-percent.js, around line 36. App doesn't load.

@MyForest
Copy link
Owner Author

Thanks for spotting that @MrTimbones

That is the peril of my local version being too divergent. I'm hoping to try and get into line over the Winter.

It's fixed now.

@MyForest
Copy link
Owner Author

I was about to wrap the call in a try...catch but it's a bit exciting because it's in the Promise list.

ofc I could wrap each Promise in the list as a call to the underlying function but that would defeat the simplicity of the Promise list.

I could move from all but ofc I want really want the drawChart call to work even if I'm not so bothered about the others.

It feels like I should stop doing the non-chart work in charts.js but then I'd need some other way to synchronize the change in timeInterval with invocations of the other things which would then look more exciting as you were trying to debug them. I'd end up re-inventing Eclipse!

Hmm.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants